Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yanky-nvim): Fix yanky.nvim loading when restoring session #555

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

chaozwn
Copy link
Contributor

@chaozwn chaozwn commented Sep 3, 2023

there can not set event 'User AstroFile', because restore session from resession.nvim will not tigger 'User AstroFile' event.

📑 Description

ℹ Additional Information

there can not set event 'User AstroFile', because restore session from resession.nvim will not tigger 'User AstroFile' event.
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title fix(editing-support): yanky not works after UIEnter. fix(yanky-nvim): yanky not works after UIEnter. Sep 3, 2023
@Uzaaft Uzaaft changed the title fix(yanky-nvim): yanky not works after UIEnter. fix(yanky-nvim): Fix yanky.nvim loading when restoring session Sep 3, 2023
@Uzaaft
Copy link
Member

Uzaaft commented Sep 3, 2023

Updated the title.
@chaozwn I don't really understand the initial "bug". Was the issue caused by "User AstroFile"?

@chaozwn
Copy link
Contributor Author

chaozwn commented Sep 3, 2023

Updated the title. @chaozwn I don't really understand the initial "bug". Was the issue caused by "User AstroFile"?

Updated the title. @chaozwn I don't really understand the initial "bug". Was the issue caused by "User AstroFile"?

This plugin overwrites our y key, but many times it starts up as not loaded, causing the y key to be unusable. Therefore, we need to advance its startup time.

@Uzaaft
Copy link
Member

Uzaaft commented Sep 3, 2023

Can't you load it after UIEnter, i.e on the event: LazyVimStarted?

@chaozwn
Copy link
Contributor Author

chaozwn commented Sep 3, 2023

After changing to LazyVimStarted, when using nvim to restore the previous page, yy becomes invalid, so we can't use this event.

@Uzaaft
Copy link
Member

Uzaaft commented Sep 3, 2023

After changing to LazyVimStarted, when using nvim to restore the previous page, yy becomes invalid, so we can't use this event.

Got it thanks for checking that out!

@Uzaaft Uzaaft merged commit e35186e into AstroNvim:main Sep 3, 2023
Per48edjes pushed a commit to Per48edjes/astrocommunity that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants