Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(copilot-lua-cmp): revert #491 #507

Merged
merged 1 commit into from
Aug 6, 2023
Merged

fix(copilot-lua-cmp): revert #491 #507

merged 1 commit into from
Aug 6, 2023

Conversation

luxus
Copy link
Member

@luxus luxus commented Aug 6, 2023

Reverts #491

fixes #497

@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited by luxus
Loading

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title Revert "chore(copilot-lua-cmp): alter accept line key mapping" revert: "chore(copilot-lua-cmp): alter accept line key mapping" Aug 6, 2023
@luxus luxus changed the title revert: "chore(copilot-lua-cmp): alter accept line key mapping" fix:(revert)"chore(copilot-lua-cmp): alter accept line key mapping" Aug 6, 2023
@luxus luxus changed the title fix:(revert)"chore(copilot-lua-cmp): alter accept line key mapping" fix(revert)"chore(copilot-lua-cmp): alter accept line key mapping" Aug 6, 2023
@luxus luxus changed the title fix(revert)"chore(copilot-lua-cmp): alter accept line key mapping" fix(revert): chore(copilot-lua-cmp): alter accept line key mapping Aug 6, 2023
@Uzaaft Uzaaft changed the title fix(revert): chore(copilot-lua-cmp): alter accept line key mapping fix(main): revert chore(copilot-lua-cmp): alter accept line key mapping Aug 6, 2023
@Uzaaft Uzaaft changed the title fix(main): revert chore(copilot-lua-cmp): alter accept line key mapping fix(copilot-lua-cmp): revert 4627023 Aug 6, 2023
@Uzaaft Uzaaft changed the title fix(copilot-lua-cmp): revert 4627023 fix(copilot-lua-cmp): revert #491 Aug 6, 2023
@Uzaaft Uzaaft merged commit 6fd39db into main Aug 6, 2023
@Uzaaft Uzaaft deleted the revert-491-chore/alter_copilot_lua_cmp_mapping branch August 6, 2023 18:11
@mehalter mehalter mentioned this pull request Aug 6, 2023
Merged
mehalter pushed a commit that referenced this pull request Aug 6, 2023
@luxus @mehalter
revert: use <C-j> for copilot acceptance (#507)
213ddc3 
Refs: aeecada
Uzaaft pushed a commit that referenced this pull request Aug 13, 2023
@luxus @Uzaaft
revert: use <C-j> for copilot acceptance (#507)
c2dc830 
Refs: aeecada
Uzaaft pushed a commit that referenced this pull request Aug 13, 2023
@luxus @Uzaaft
revert: use <C-j> for copilot acceptance (#507)
115b88b 
Refs: aeecada
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzaaft Uzaaft Uzaaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copilot-lua-cmp breaks default cmp <C-n> binding
2 participants
@luxus @Uzaaft