Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zen-mode-nvim): ensure winbar stays disabled and restore old mini.indentscope options #439

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

Subjective
Copy link
Contributor

@Subjective Subjective commented Jul 14, 2023

Previously, the winbar would enable itself on various events (switching buffers, writing to file, which-key popups, telescope, etc.) I added an autocmd that will disable the winbar for all these events while ZenMode is enabled. This does feel a bit hacky though, so please let me know if there's a better way to toggle the winbar.

Additionally, this fixes an issue where previous mini.indentscope options would not be restored upon exiting ZenMode.

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Subjective Subjective force-pushed the patch-13 branch 3 times, most recently from 79ca1f8 to a89c112 Compare July 14, 2023 12:25
@owittek
Copy link
Member

owittek commented Jul 14, 2023

Could you please elaborate the PR and/or split the changes in two commits? The refactor makes it really hard to follow the changes.

Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@owittek owittek merged commit 8aa739a into AstroNvim:main Jul 14, 2023
mehalter pushed a commit that referenced this pull request Jul 15, 2023
@Subjective Subjective deleted the patch-13 branch July 18, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants