Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vimtex): add which-key mapping descriptions #394

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Subjective
Copy link
Contributor

@Subjective Subjective commented Jul 9, 2023

Before

image

After

image

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Uzaaft
Uzaaft approved these changes Jul 10, 2023
@Uzaaft Uzaaft self-requested a review July 10, 2023 03:55
@Uzaaft
Copy link
Member

Uzaaft commented Jul 10, 2023

@Subjective Why didn't you use the keys table in lazy.nvim to setup the keys?

@Subjective
Copy link
Contributor Author

@Uzaaft VimTex sets up the keybinds by default upon entering a latex buffer, but doesn't add the descriptions necessary for which-key. The main reason for not using the lazy table is that I want the labels to be specific to that buffer.

@Uzaaft Uzaaft requested a review from a team July 10, 2023 06:17
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks. Just be sure to track the changes on vimtex and come back when these mappings inevitably change 😅

@mehalter mehalter merged commit a49863d into AstroNvim:main Jul 10, 2023
@Subjective Subjective deleted the patch-8 branch July 18, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants