Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utilities): add transparent plugin #180

Merged
merged 4 commits into from
May 2, 2023

Conversation

0xricksanchez
Copy link
Contributor

@0xricksanchez 0xricksanchez commented May 2, 2023

Adds https://github.com/xiyaowong/transparent.nvim as an option for themes that don't support transparency :)

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@owittek
Copy link
Member

owittek commented May 2, 2023

please rename the folder from transparent to transparent-nvim to be consistent with other plugins. LGTM otherwise!

Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owittek owittek merged commit 49e9a39 into AstroNvim:main May 2, 2023
@0xricksanchez 0xricksanchez deleted the add_transparent branch May 2, 2023 09:15
@0xricksanchez 0xricksanchez changed the title feat: add transparent plugin feat(utilities): add transparent plugin May 2, 2023
@Hugo-CASTELL
Copy link
Contributor

Hugo-CASTELL commented May 13, 2023

I'm not able to import the plugin using these methods (i've tried its separately) :
image
image
But i can import neodim.

Am i missing something ? (sorry for my poor english btw)

@Hugo-CASTELL
Copy link
Contributor

@0xricksanchez

@0xricksanchez
Copy link
Contributor Author

@Hugo-CASTELL it works fine for me with this line:

  { import = "astrocommunity.utility.transparent-nvim",           enabled = true },

@bpqm
Copy link
Contributor

bpqm commented May 17, 2023

@0xricksanchez it does not work for me, so weird, I select TransparentEnable or TransparentToggle, nothing happen

the env is

image

kitty version 0.28.1

astronvim 3.15.7

my theme is "dracula-nvim" https://github.com/AstroNvim/astrocommunity/tree/main/lua/astrocommunity/colorscheme/dracula

config file
image

@0xricksanchez
Copy link
Contributor Author

0xricksanchez commented May 17, 2023

I can confirm it works fine for me on the kanagawa color scheme... I noticed it breaks on:

  • catppuccin: telescope but no nvimtree transparency,
  • tokyonight: no telescope and no nvimtree transparency
  • rose-pine: no telescope transparency

This seems to be a limitation/problem with the transparent plugin or missing fields in the extra_groups option. Looks like I didn't notice this because I used a color scheme that was working out of the box.

As this is a merged PR, I highly recommend creating a new issue or bringing this discussion over to the discord server, where others could take a look as well.

// Edit: Created a thread here: https://discord.com/channels/939594913560031363/1078005571451621546/threads/1108330828276170854

@0xricksanchez
Copy link
Contributor Author

Also asked nicely in xiyaowong/transparent.nvim#41

@Hugo-CASTELL
Copy link
Contributor

Thanks a lot for your answers. I could enable it. I confirm the bugs you raised. Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants