Adding cosmology to the configuration dictionary #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazkiaei
commented
Jun 17, 2019
mocks/mocks.py
Outdated
| @@ -140,6 +142,7 @@ def parse_config(config_file='config_example.yaml', | |||
| # Redshift | |||
| config['redshift'] = kwargs.get('redshift', | |||
| config['redshift']) | |||
| config['cosmology'] = mocks.create_cosmology(config) | |||
There was a problem hiding this comment.
I am not sure about using the function create_cosmology inside the function parse_config. Any advice about that?
Codecov Report
@@ Coverage Diff @@
## develop #85 +/- ##
==========================================
+ Coverage 99.1% 99.1% +<.01%
==========================================
Files 5 5
Lines 558 561 +3
==========================================
+ Hits 553 556 +3
Misses 5 5
Continue to review full report at Codecov.
|
|
@AstroHuntsman/spiderlings |
|
@AstroHuntsman/arachne |
|
With respect to the advice that I received, cosmology should not be added to the configuration, so, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code uses a cosmology several times and to avoid creating it I thought maybe it should have it inside the configuration dictionary.
#71