Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating property/method names in server #58

Merged
merged 1 commit into from
Oct 11, 2019
Merged

updating property/method names in server #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions domehunter/gRPC-server/hx2dome.proto_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def dapiGotoAzEl(self, request, context):
else:
return_code = 0
try:
self.dome.GotoAz(request.az)
self.dome.goto_az(request.az)
except Exception:
# TODO: proper error handling
return_code = 1
Expand Down Expand Up @@ -471,10 +471,10 @@ def dapiIsFindHomeComplete(self, request, context):
return response
else:
is_dome_moving = self.dome.dome_in_motion
# if dome is not moving and dome.is_home returns True
# if dome is not moving and dome.at_home returns True
# lets just consider the command complete
# TODO: better method of determine command completion
is_complete = not is_dome_moving and self.dome.is_home
is_complete = not is_dome_moving and self.dome.at_home
response = hx2dome_pb2.IsComplete(
return_code=0, is_complete=is_complete)
return response
Expand Down