Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat warnings as errors in testing #63

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

hugobuddel
Copy link
Contributor

Raises #61 and #62

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.60%. Comparing base (ea28f9c) to head (268a01f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   56.60%   56.60%           
=======================================
  Files           8        8           
  Lines         795      795           
=======================================
  Hits          450      450           
  Misses        345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@teutoburg teutoburg added the tests Related to unit or integration tests label Nov 17, 2024
@hugobuddel hugobuddel merged commit bb866cf into main Nov 17, 2024
20 checks passed
@hugobuddel hugobuddel deleted the hb/warnings_as_errors branch November 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to unit or integration tests
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants