Add final rewards+final used fee #75

johnnyji-dev · 2024-03-07T14:59:23Z

No description provided.

- After completing transaction, need to retrieve a final claimed reward and used fee.

gtg7784 · 2024-05-27T13:03:25Z

Hi @johnnyji-dev thank you for your contribution. Can you please add the PR dscription?

johnnyji-dev · 2024-05-29T01:02:57Z

Hi @johnnyji-dev thank you for your contribution. Can you please add the PR dscription?

Is there any template for PR description? Is there no format?
Can I just write down description for my PR?
BTW, I checked out my PR and it need to update on "claimedReward" method.

I completed to update and test that method.
I am going to retry to PR.

gtg7784 · 2024-05-29T01:44:07Z

Hi @johnnyji-dev thank you for your contribution. Can you please add the PR dscription?

Is there any template for PR description? Is there no format? Can I just write down description for my PR? BTW, I checked out my PR and it need to update on "claimedReward" method.

I completed to update and test that method. I am going to retry to PR.

Hi, you can write summary of updates in this PR without template.

Please update the description and check that claimedReward method (and why it's needed)

thank you for your contribution.

gtg7784 · 2024-05-29T01:45:34Z

and also, please run lint before commit your updates. thank you

johnnyji-dev · 2024-05-29T15:11:07Z

@gtg7784
[Adding Two Methods]

Background : After broadcasting an extrinsic, we need to retrieve "usedFee" or "claimedReward" amount.
"usedFee" and "claimedReward" methods are added on "packages/sdk-core/src/modules/dapp-staking/pending-rewards/index.ts".
We can get the value by 'extrinsic-hash' and 'block-number'.
After stakingV3, There are two types of rewards (bonus and claim).
"claimedReward" serves the total(bonus + claim) reward.

It need to merge the commit (77dc1cec6fb9c32a32c7820c0aacc1cecdb08e24).

bobo-k2 · 2024-06-19T07:25:09Z

Hi @johnnyji-dev on more thing. Can you please uplift version in package.json (there are multiple files) from 0.2.9 to 0.3.0

johnnyji-dev · 2024-06-23T08:00:38Z

Hi @johnnyji-dev on more thing. Can you please uplift version in package.json (there are multiple files) from 0.2.9 to 0.3.0

@bobo-k2

I uplifted version in package.json (there are multiple files) to 0.3.0

impelcrypto

Hi @johnnyji-dev
Thank you for your contribution. Could you help update the version number to 0.3.0 (there are required updating in multiple package.json files)? Thanks in advance.

Ref:
https://github.com/AstarNetwork/astar.js/pull/69/files

bobo-k2 · 2024-07-08T08:18:09Z

packages/sdk-core/src/modules/dapp-staking/pending-rewards/index.ts

+    let usedFee = BigInt('0');
+
+    extrinsicEvents.map((e) => {
+      if (e.toHuman()?.event?.method == method &&


Can you avoid using toHuman and use polkadot.js types instead. This will also remove need for commaStrToBigInt
The same applies for the method above

impelcrypto · 2024-07-08T08:21:46Z

Could you run yarn lint? CI failed in lint and build .

johnnyji-dev · 2024-07-08T08:35:54Z

After work, I will check them out. Thx~ 2024년 7월 8일 (월) 오후 5:22, Roy ***@***.***>님이 작성:

…

Could you run yarn lint? CI failed in lint and build . — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A53U4LRLMGZCEN2RX4A3RUTZLJD27AVCNFSM6AAAAABELFDJAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJTGM2DENBXGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

bobo-k2

Hi @johnnyji-dev, please address the following

fix build errors
provide PR description and explain what you did and why those changes are needed
Update SDK-Core Library Functions section in README.md
Have in mind that there are actually three different reward events in case you want to also handle the third one https://github.com/AstarNetwork/Astar/blob/150b11c4ffabaf82f6c1ec165bfa5d99340c8358/pallets/dapp-staking-v3/src/lib.rs#L301

johnnyji-dev · 2024-07-21T08:21:50Z

Hi @johnnyji-dev, please address the following

fix build errors

provide PR description and explain what you did and why those changes are needed

Update SDK-Core Library Functions section in README.md

Have in mind that there are actually three different reward events in case you want to also handle the third one https://github.com/AstarNetwork/Astar/blob/150b11c4ffabaf82f6c1ec165bfa5d99340c8358/pallets/dapp-staking-v3/src/lib.rs#L301

Updated method name (claimedReward to getClaimedReward & UsedFee to getUsedFee)
Updated README.md file ( add getClaimedReward() & getUsedFee() description. )
Add "Dapp Reward" case on getClaimedReward()

bobo-k2 · 2024-07-22T09:53:56Z

Hi @johnnyji-dev, please address the following

fix build errors

provide PR description and explain what you did and why those changes are needed

Update SDK-Core Library Functions section in README.md

Have in mind that there are actually three different reward events in case you want to also handle the third one https://github.com/AstarNetwork/Astar/blob/150b11c4ffabaf82f6c1ec165bfa5d99340c8358/pallets/dapp-staking-v3/src/lib.rs#L301

Updated method name (claimedReward to getClaimedReward & UsedFee to getUsedFee)

Updated README.md file ( add getClaimedReward() & getUsedFee() description. )

Add "Dapp Reward" case on getClaimedReward()

Hi @johnnyji-dev you forgot the most important point. The code is not building

…d.json)

johnnyji-dev · 2024-07-22T15:03:06Z

Hi @johnnyji-dev, please address the following

fix build errors

provide PR description and explain what you did and why those changes are needed

Update SDK-Core Library Functions section in README.md

Have in mind that there are actually three different reward events in case you want to also handle the third one https://github.com/AstarNetwork/Astar/blob/150b11c4ffabaf82f6c1ec165bfa5d99340c8358/pallets/dapp-staking-v3/src/lib.rs#L301

Updated method name (claimedReward to getClaimedReward & UsedFee to getUsedFee)

Updated README.md file ( add getClaimedReward() & getUsedFee() description. )

Add "Dapp Reward" case on getClaimedReward()

Hi @johnnyji-dev you forgot the most important point. The code is not building

Oh, I missed that part!! And complete to update it.

bobo-k2

Still missing the PR description. Explain reasons for the change

bobo-k2 · 2024-07-23T06:57:24Z

packages/sdk-core/src/modules/dapp-staking/pending-rewards/index.ts

@@ -321,7 +322,7 @@ export const getUsedFee = async (
    const blockHash = await api.rpc.chain.getBlockHash(height);
    const signedBlock = await api.rpc.chain.getBlock(blockHash);
    const apiAt = await api.at(signedBlock.block.header.hash);
-    const allRecords = (await apiAt.query.system.events()).toArray();
+    const allRecords: any = await apiAt.query.system.events();


Please don't use any Applicable to multiple locations within the code
https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html

@bobo-k2
BTW, Property 'map' does not exist on type 'Codec'.
The type of 'allRecords' is Codec.
I tried to iterate the data by using 'filter' or 'map'. But that make build error(yarn polkadot-exec-tsc --build tsconfig.build.json).

How can I handle this? Can you suggest any reference docs?

Codec is a base type from which all polkadot.js types are inherited. System.events are of type Vec<FrameSystemEventRecord> so you can change your line to

const allRecords = await api.query.system.events<Vec<FrameSystemEventRecord>>();

When '<Vec>' applied, can not import the member like below error message.
packages/sdk-core/src/modules/dapp-staking/pending-rewards/index.ts:7:10 - error TS2305: Module '"@polkadot/types/lookup"' has no exported member 'FrameSystemEventRecord'.

Alternative, I used the 'EventRecord' and got properties(actualFee, amount) by index.

johnnyji-dev added 2 commits March 6, 2024 09:42

add some api(claimedReward, UsedFee).

83ba6ec

- After completing transaction, need to retrieve a final claimed reward and used fee.

update claimedReward & usedFee param (address to extrinsicHash)

af8b38f

gtg7784 self-requested a review April 9, 2024 11:43

update claimedReward(Claim_staker_rewards & Claim_bonus_reward)

77dc1ce

gtg7784 requested review from bobo-k2 and removed request for gtg7784 June 9, 2024 18:25

fix: version change 0.2.8 => 0.3.0 on package.json

3f0e8e5

Merge branch 'main' into add_FinalRewards+FinalUsedFee

1c6b8db

bobo-k2 approved these changes Jul 8, 2024

View reviewed changes

bobo-k2 requested review from impelcrypto and gtg7784 July 8, 2024 06:41

gtg7784 approved these changes Jul 8, 2024

View reviewed changes

impelcrypto suggested changes Jul 8, 2024

View reviewed changes

bobo-k2 suggested changes Jul 8, 2024

View reviewed changes

johnnyji-dev added 2 commits July 8, 2024 23:24

fix : yarn lint - modification

b44464d

fix : remove toHuman() & commaStrToBigInt()

8b229d5

johnnyji-dev requested review from bobo-k2, gtg7784 and impelcrypto July 19, 2024 04:50

bobo-k2 suggested changes Jul 19, 2024

View reviewed changes

fix : add DAppReward on claimedReward & update README.md

6a75c9a

johnnyji-dev added 3 commits July 21, 2024 17:15

fix : update UsedFee() to getUsedFee()

239e162

fix : update UsedFee() to getUsedFee() on README.md

e0b1ce0

fix : Update claimedReward to getClaimedReward

77c3d69

johnnyji-dev requested a review from bobo-k2 July 22, 2024 01:12

fix : update build-error(yarn polkadot-exec-tsc --build tsconfig.buil…

29a523f

…d.json)

bobo-k2 suggested changes Jul 23, 2024

View reviewed changes

johnnyji-dev added 2 commits July 29, 2024 16:07

fix : apply <Vec<EventRecord>> on system.events & delete any

0c90c28

fix : delete the unusing comments

49820fa

johnnyji-dev requested a review from bobo-k2 July 29, 2024 09:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add final rewards+final used fee #75

Add final rewards+final used fee #75

johnnyji-dev commented Mar 7, 2024

gtg7784 commented May 27, 2024

johnnyji-dev commented May 29, 2024

gtg7784 commented May 29, 2024

gtg7784 commented May 29, 2024

johnnyji-dev commented May 29, 2024 •

edited

Loading

bobo-k2 commented Jun 19, 2024

johnnyji-dev commented Jun 23, 2024 •

edited

Loading

impelcrypto left a comment •

edited

Loading

bobo-k2 Jul 8, 2024

impelcrypto commented Jul 8, 2024

johnnyji-dev commented Jul 8, 2024 via email

bobo-k2 left a comment

johnnyji-dev commented Jul 21, 2024

bobo-k2 commented Jul 22, 2024

johnnyji-dev commented Jul 22, 2024

bobo-k2 left a comment

bobo-k2 Jul 23, 2024

johnnyji-dev Jul 24, 2024

bobo-k2 Jul 25, 2024

johnnyji-dev Jul 29, 2024

Add final rewards+final used fee #75

Are you sure you want to change the base?

Add final rewards+final used fee #75

Conversation

johnnyji-dev commented Mar 7, 2024

gtg7784 commented May 27, 2024

johnnyji-dev commented May 29, 2024

gtg7784 commented May 29, 2024

gtg7784 commented May 29, 2024

johnnyji-dev commented May 29, 2024 • edited Loading

bobo-k2 commented Jun 19, 2024

johnnyji-dev commented Jun 23, 2024 • edited Loading

impelcrypto left a comment • edited Loading

Choose a reason for hiding this comment

bobo-k2 Jul 8, 2024

Choose a reason for hiding this comment

impelcrypto commented Jul 8, 2024

johnnyji-dev commented Jul 8, 2024 via email

bobo-k2 left a comment

Choose a reason for hiding this comment

johnnyji-dev commented Jul 21, 2024

bobo-k2 commented Jul 22, 2024

johnnyji-dev commented Jul 22, 2024

bobo-k2 left a comment

Choose a reason for hiding this comment

bobo-k2 Jul 23, 2024

Choose a reason for hiding this comment

johnnyji-dev Jul 24, 2024

Choose a reason for hiding this comment

bobo-k2 Jul 25, 2024

Choose a reason for hiding this comment

johnnyji-dev Jul 29, 2024

Choose a reason for hiding this comment

johnnyji-dev commented May 29, 2024 •

edited

Loading

johnnyji-dev commented Jun 23, 2024 •

edited

Loading

impelcrypto left a comment •

edited

Loading