Fix dApp swiper configuration #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3ff1717): https://astar-apps--pr1317-fix-dapps-swiper-skjovcws.web.app (expires Fri, 21 Jun 2024 09:59:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
gtg7784
reviewed
Jun 14, 2024
| @@ -99,7 +99,7 @@ export default defineComponent({ | |||
| .map((x) => ({ | |||
| name: x.name, | |||
| iconUrl: x.iconUrl, | |||
| amount: x.rewardAmount, | |||
| amount: BigInt(x.rewardAmount), | |||
There was a problem hiding this comment.
export type PeriodData = {
dappAddress: string;
rewardAmount: bigint;
stakeAmount: bigint;
};
I think it's already bigint
There was a problem hiding this comment.
Me too, but it is treated as string, most likely the value comes as string from API. I will check and cast immediately after fetching.
There was a problem hiding this comment.
Fixed in cdf64d0
coverting to big int as soon as data is received
Kahonnohak
approved these changes
Jun 14, 2024
gtg7784
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Add dApp staking categories description (#1316) * Fix dApp swiper configuration (#1317) * Fix dApp swiper configuration * Rewards earned sort fix * TVL ratio for previous period calculation fix * Hide period stats * Cast to bigint * Hide period stats * Fix for filtering dApps in other category (#1322) * Category filter fix, take 2 (#1323) * add airlyft to promotions (#1319) * Show estimated staker + bonus rewards on vote info banner (#1329) * Show estimated staker + bonus rewards on vote info banner * Text update * dApp Staking ranked tier update (#1324) * Fetch rank rewards * Add Hydration to XCM (#1315) * Add rank reward calculation * Map rankTier * Type bug fix * voting banner wording fix --------- Co-authored-by: green-jay <[email protected]> * Tier display fix (#1331) * hotfix: added maintenance mode condition to disable the bridge feature (#1330) * Add Hydration to XCM (#1315) * hotfix: disabled zKyoto bridge --------- Co-authored-by: green-jay <[email protected]> --------- Co-authored-by: Bobo <[email protected]> Co-authored-by: Rachit Magon <[email protected]> Co-authored-by: green-jay <[email protected]>
gtg7784
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Add dApp staking categories description (#1316) * Fix dApp swiper configuration (#1317) * Fix dApp swiper configuration * Rewards earned sort fix * TVL ratio for previous period calculation fix * Hide period stats * Cast to bigint * Hide period stats * Fix for filtering dApps in other category (#1322) * Category filter fix, take 2 (#1323) * add airlyft to promotions (#1319) * add Pinky data to data_promotion * add pinky.jpg --------- Co-authored-by: Bobo <[email protected]> Co-authored-by: Rachit Magon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fix for misconfigured swiper in voting component's dApps list
Fix for sorting dApps by claimed rewards
Fix for TVL ratio in period stats component
Check list