Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to polkadot-v0.9.40 #948

Merged
merged 21 commits into from
Jul 5, 2023
Merged

Update to polkadot-v0.9.40 #948

merged 21 commits into from
Jul 5, 2023

Conversation

ashutoshvarma
Copy link
Member

@ashutoshvarma ashutoshvarma commented May 31, 2023

Pull Request Summary

What does it do?

  • update to v0.9.40

Important Changes

(below list is not exhaustive and this PR also)

Substrate (v0.9.40)

Polkadot

Cumulus (9400)

Frontier

Check list

  • added or updated unit tests
  • follow-up pallet assets RPC
  • updated Astar official documentation
  • tests using try-runtime for all chains
  • updated spec version
  • updated semver

@ashutoshvarma ashutoshvarma added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. labels May 31, 2023
runtime/astar/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump up spec version for all runtimes except local and bump up minor version for semver.

Not sure what to do about the clippy error though.

@ashutoshvarma
Copy link
Member Author

ashutoshvarma commented Jun 21, 2023

@Dinonard Should I bump minor version for node as well? Since this PR modifies client too.

@Dinonard
Copy link
Member

@ashutoshvarma EVM tracing cargo check is failing.

@ashutoshvarma
Copy link
Member Author

cargo check --features evm-tracing --locked

Working fine locally, let me re-run the jobs to see if that fix it.

@Dinonard Dinonard requested a review from shaunxw June 29, 2023 08:02
@Dinonard
Copy link
Member

Please include latest master and let's see if it helps.

As far as I'm concerned, let's go with the merge once CI works.

Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are collator code changes. Could you do a Zombienet test to make sure block production works?

runtime/astar/src/lib.rs Outdated Show resolved Hide resolved
@ashutoshvarma
Copy link
Member Author

@shaunxw I've tested with zombienet and blocks are producing just fine.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Code Coverage

Package Line Rate Branch Rate Health
pallets/custom-signatures/src 52% 0%
precompiles/sr25519/src 79% 0%
precompiles/assets-erc20/src 76% 0%
pallets/block-reward/src 85% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/pallet-xvm/src 5% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/utils/macro/src 0% 0%
chain-extensions/pallet-assets/src 0% 0%
precompiles/xcm/src 85% 0%
precompiles/xvm/src 61% 0%
primitives/src 70% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/xc-asset-config/src 54% 0%
pallets/dapps-staking/src 82% 0%
pallets/dapps-staking/src/pallet 87% 0%
precompiles/utils/src 69% 0%
primitives/src/xcm 70% 0%
pallets/collator-selection/src 70% 0%
chain-extensions/dapps-staking/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/pallet-xcm/src 54% 0%
pallets/contracts-migration/src 0% 0%
pallets/pallet-xvm/src/pallet 8% 0%
Summary 55% (2196 / 3996) 0% (0 / 0)

Minimum allowed line rate is 50%

@shaunxw shaunxw merged commit 3f37b4c into master Jul 5, 2023
@shaunxw shaunxw deleted the temp/polkadot-v0.9.40 branch July 5, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar client This PR/Issue is related to the topic “client”. runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants