[WIP] 2.0.0 changes #336
[WIP] 2.0.0 changes #336
Conversation
|
|
||
| ## Installation | ||
|
|
||
| Add the gem to your Gemfile | ||
|
|
||
| ``` ruby | ||
| gem 'asset_sync' | ||
| gem "asset_sync" |
There was a problem hiding this comment.
I think that can be removed? Because you always need to add a provider which is described below?
| If you prefer to load fewer classes into your application, which will reduce load time and memory use, | ||
| you need to load those parts of Fog yourself *before* loading AssetSync: | ||
| Asset Sync has no idea about what provider will be used, | ||
| so you are responsible for bundling the right gem for the provided to be used. |
| ``` | ||
|
|
||
| If you don't install the required gem, | ||
| Fog will complain (by exception) about it when provider is set by Asset Sync. |
There was a problem hiding this comment.
I don't know if you should keep a require "fog/core" in the lib/asset_sync.rb. Normally it shouldn't be needed, because if you add a provider, the provider requires it. But If you don't do that, then Fog can't complain about it, because Asset Sync doesn't even find Fog.
|
@SuperTux88 |
| @@ -1,4 +1,6 @@ | |||
| require File.dirname(__FILE__) + '/../spec_helper' | |||
| require "fog/core" | |||
| @@ -1,4 +1,5 @@ | |||
| require File.dirname(__FILE__) + '/../spec_helper' | |||
| require "fog/core" | |||
|
@SuperTux88 I have given up on making integration spec green. |
|
I will release this within this week (unless I forgot o_0 |
|
About the spec: I haven't tested anything, only reviewed the changes. But I assume that it is also broken without your changes? |
|
The integration fails since complains about access key / secret key missing |
PikachuEXE
force-pushed
the
upgrade/asset_sync/2.0.0
branch
from
e8deafd to
3f50a11
Compare
|
@SuperTux88 |
Main changes
fog-coreinstead offog