-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using fog-aws instead of fog as dependency #295
Conversation
I just deployed using my branch and it all worked fine 💃
|
+1 for this change, when you install the latest full "fog" gem it depends on like 15 gems for each provider, when we actually only need one. |
ping @davidjrice @rumblelabs? |
+1 Asset sync is made specifically for S3 (according to the docs) So no need to include the fog gem which loads:
|
@davidjrice Any update on this? |
Please can we get this into a new asset_sync release? We are trying to reduce gem bloat, and pulling in all of the fog is excessive bloat. |
@rumblelabs any idea if we can get this merged? It seems to not break anything and a simple change. Also it's super obvious we don't need the whole fog dependencies in here. We tried to use the fog loading before the asset_sync but it doesn't seem to work. |
We are very needing this. |
Please merge. |
This indeed seems like a good improvement to me. 👍 I'd like to give this a try locally before merging, especially since our Travis build is out of shape at the moment. Sadly I won't have any time at all this week. I'll give it a look next week, but feel free to ping me if that doesn't happen. :) |
I am only a new member so I will let the project owner decide. |
|
Please don't merge this yet. I'm opening the PR so travis tests it :)
As discussed in #292, this is a possible solution to use
fog-aws
instead offog
.As
fog-aws
is fairily new, there are a couple of problems:fog-aws
so I just chose the most recent one.