Add setting to control the public ACL on uploaded files #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Is there a way to currently use this without monkey-patching? |
|
No longer valid? |
|
I didn't get a response to it, and I'm unfortunately no longer actively working on projects using Rails these days, which is what prompted me to close it. It's been so long since I first created the pull request that I've foolishly managed to delete the original fork containing the code while "cleaning up" my unused repos. I'm impressed GitHub still manages to hang onto the original commit despite this. It was a fairly small change though, so if anyone still wants this feature they can probably still make use of these changes? |
|
Sure :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a page from CarrierWave's book, I added a
fog_publicconfig option to control the setting of the public ACL on uploaded files.This would solve #208 for people who prefer to use bucket policies instead of ACLs.