Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of fog options from .fog file #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

locochris
Copy link

ie. remove all the validations and just let fog worry about it
(which BTW it does)

@locochris
Copy link
Author

NB. This also allows the use of rackspace_cdn_ssl: true from the ~/.fog file so asset_host can be set to use the correct public_url otherwise it will use the non-ssl public_url.

eg. in rails config/application.rb

# Set assets host
require 'asset_sync'
config.action_controller.asset_host = AssetSync.storage.bucket.public_url if AssetSync.enabled?

@locochris
Copy link
Author

Plus the rackspace_servicenet: true option in ~/.fog (to allow connecting to Rackspace cloudfiles over internal IP addresses, which is apparently faster and free).
http://www.rackspace.com/knowledge_center/article/connecting-to-cloudfiles

@davidjrice
Copy link
Contributor

Not sure about this yet, but can you please rebase off of master, hopefully build will then be passing and we can look further at getting merged in

ie. remove all the validations and just let fog worry about it
(which BTW it does)
@locochris
Copy link
Author

Rebased.

I'll let you decide whether or not its your concern to validate parameters that you pass to an external library.
My only requirement is that I need some way of passing these extra options on to fog.
(ie. rackspace_cdn_ssl and rackspace_servicenet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants