-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional support for CORS requests for assets on rackspace #149
base: master
Are you sure you want to change the base?
Conversation
added rackspace CORS headers info.
markup fix.
👍 Is this project still active @rumblelabs ? |
Yes, it is. However we do not have automated integration tests for rackspace yet. Mainly as it's not a service I use... I'm 👍 on this too, need to get the time to bring in some tests and merge this in On Sunday, 24 March 2013 at 02:17, Trae Robrock wrote:
|
Ok great. I can help out here if needed. Also if it helps I'm using this
|
Hey, can you please rebase this, hopefully the build will pass and we can look at getting it merged in, cheers. |
Could you clarify on :custom_headers config parameter. Does is replace the CORS fix? |
…ure if one of the files failed to upload. always_upload_all - will always upload all files.
Not my intention to replace the CORS addition, it is something that needs thought about and merged between the two streams of development. Perhaps an internal dsl for supplying rules of what to do with different types of assets On Tuesday, 30 April 2013 at 01:33, fountainheadpro wrote:
|
Got it. One more question, why not always use MIME::Types? Rack::Mime gives me problems specifically with .ttf for fonts. |
upload_file f | ||
rescue Exception => ex | ||
log "error - #{$!} - file: #{f}" | ||
railse ex unless config.warn_on_failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be raise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixed.
I'm using this successfully too (thanks fountainheadpro). Just wanted to let you know of the interest for this (or another mechanism of setting the CORS options on Rackspace) to be integrated. |
Would be great to see it integrated, so I can stop using my fork for the On Mon, Oct 21, 2013 at 3:41 AM, Joseph Lord [email protected]:
|
@fountainheadpro I was able to stop the above #234 issue via including |
@rumblelabs any chance of getting this one integrated? |
@davidjrice Is this going to be merged at some point? I've had it running fine on Heroku for about 9 months now. |
@tosbourn Any chance you can get to this PR. I and several others are using it already. |
👍 |
FWIW I was able to get the same kind of header access simply using:
in my asset_sync.rb file. |
Rackspace does not support CORS policy management from web console and requeres API calls to set CORS headers. This patch adds the CORS headers to the file upload operation, so the assets are becoming available for CORS requests.