fix: Update binaryen's constants #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Nov 22, 2020
dcodeIO
reviewed
Nov 22, 2020
| SqrtF32x4 = 87 /* _BinaryenSqrtVecF32x4 */, | ||
| CeilF32x4 = 88 /* _BinaryenCeilVecF32x4 */, | ||
| FloorF32x4 = 89 /* _BinaryenFloorVecF32x4 */, | ||
| NegI16x8 = 74 /* _BinaryenNegVecI16x8 */, |
There was a problem hiding this comment.
This one is strange. Order should be: https://github.com/WebAssembly/binaryen/blob/68294338a1cc7337e808671e75933b1134d18a90/src/wasm.h#L163-L166
BitmaskVecI8x16
PopcntVecI8x16 // new
AbsVecI16x8
NegVecI16x8
meaning something is off here since the missing one is before AbsVecI16x8, not between AbsVecI16x8 and NegVecI16x8 hmm.
dcodeIO
reviewed
Nov 22, 2020
| WidenHighI16x8ToI32x4 = 112 /* _BinaryenWidenHighSVecI16x8ToVecI32x4 */, | ||
| WidenLowU16x8ToU32x4 = 113 /* _BinaryenWidenLowUVecI16x8ToVecI32x4 */, | ||
| WidenHighU16x8ToU32x4 = 114 /* _BinaryenWidenHighUVecI16x8ToVecI32x4 */ | ||
| TruncSatF32x4ToI32x4 = 100 /* _BinaryenTruncSatSVecF32x4ToVecI32x4 */, |
There was a problem hiding this comment.
dcodeIO
reviewed
Nov 22, 2020
dcodeIO
reviewed
Nov 22, 2020
dcodeIO
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1551