Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding readOnly attributes to fix comments and fixing 2018_07_10 migration examples #14

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Adding readOnly attributes to fix comments and fixing 2018_07_10 migration examples #14

merged 2 commits into from
Dec 10, 2019

Conversation

anmolbhatia289
Copy link

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@anmolbhatia289 anmolbhatia289 merged commit 1ca25ba into master Dec 10, 2019
prsadhu-ms-idc pushed a commit that referenced this pull request Jul 6, 2021
@larisaborodina @rjaini @larysaborodina
[AzureStack] [Admin API] ACR Admin swagger spec changes (Azure#14290)
76f34ff 
* ACR Admin swagger spec changes

* Release/larisab (#1)

* Add swagger spec for acr setup.

* Add swagger spec for acr setup - fixed jsons.

* Add swagger spec for acr setup - address feedback to convert get status to post.

* Add swagger spec for acr setup - fixed typo.

* Add swagger spec for acr setup - added setup specs to readme.

* Add swagger spec for acr setup - fixed checkSetup definitions.

* Add swagger spec for acr setup - addressed comments.

* Add swagger spec for acr setup - addressed ARM feedback.

* Add swagger spec for acr setup - added proper input-files n readme.

* Add swagger spec for acr setup - fixed inavalid scheme.

* Add swagger spec for acr setup - fixed inavalid method Post instaed of Get.

Co-authored-by: Larysa Borodina <[email protected]>

* Update API changes (#2)

* Update API changes

* Add delete call implementation

* update examples

* Fix swagger validation errors. (#3)

* Fix swagger validation errors - 2-nd. (#4)

* Fix model validation fix

* Fix swagger validation errors - 3d. (#5)

* Fix swagger validation errors - 4th. (#6)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Release/acrchanges (#8)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Release/acrchanges (#9)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Release/larisab (#11)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 12th.

* Release/acrchanges (#12)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Release/acrchanges (#13)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Release/acrchanges (#14)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Release/acrchanges (#15)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Release/acrchanges (#16)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Release/acrchanges (#17)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Release/acrchanges (#18)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Release/acrchanges (#19)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Release/acrchanges (#20)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Release/acrchanges (#21)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Release/acrchanges (#22)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Release/acrchanges (#23)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Release/acrchanges (#24)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Release/acrchanges (#25)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Use v2 common resource types.

* Release/acrchanges (#26)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Use v2 common resource types.

* Use v2 common resource types for parameters also.

* Release/acrchanges (Azure#27)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Use v2 common resource types.

* Use v2 common resource types for parameters also.

* Use v2 common resource types for parameters also. - fixed the readme to remove unneeded file

Co-authored-by: Rohit Jaini <[email protected]>
Co-authored-by: larysaborodina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lshai06 lshai06 lshai06 approved these changes

@DevBaburaj DevBaburaj Awaiting requested review from DevBaburaj

@avneeshrai avneeshrai Awaiting requested review from avneeshrai avneeshrai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmolbhatia289 @lshai06