Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webapp - lang-switcher: error on the lang attribute #29

Closed
dzc34 opened this issue Feb 18, 2017 · 0 comments
Closed

webapp - lang-switcher: error on the lang attribute #29

dzc34 opened this issue Feb 18, 2017 · 0 comments

Comments

@dzc34
Copy link
Member

dzc34 commented Feb 18, 2017

Configuration

Contrast-Finder v0.4.4

Observed behaviour

?lang=en

<div id="lang-switcher"> 
        <strong lang="en">english</strong> 
        <a lang="fr" href="?lang=fr" title="Passer en français" >français</a>
 </div>

?lang=fr

<div id="lang-switcher"> 
        <a href="?lang=en" title="Switch to english">english</a>
        <strong lang="en">français</strong>
 </div>

Expected behaviour

?lang=en

<div id="lang-switcher"> 
        <strong>english</strong> 
        <a lang="fr" href="?lang=fr" title="Passer en français" >français</a>
 </div>

?lang=fr

<div id="lang-switcher"> 
        <a lang="en" href="?lang=en" title="Switch to english">english</a>
        <strong>français</strong>
 </div>
@dzc34 dzc34 changed the title lang-switcher webapp - lang-switcher: error on the lang attribute Feb 18, 2017
@dzc34 dzc34 closed this as completed in 09a2f73 Feb 19, 2017
dzc34 added a commit to dzc34/Contrast-Finder that referenced this issue Mar 29, 2017
----------------------

  set version to 0.4.5
  fixed CHANGELOG
  webapp LOG: fixed  daily rollover
  update CHANGELOG
  fixed Asqatasun#34 HTML errors
  typo
  delete unused file
  webapp - Updated *.xml: Delete *.xsd if not used (2/2)
  Updated CHANGELOG
  webapp - Updated *.xml: Delete *.xsd if not used
  Fixed Asqatasun#31 - Revert "webapp: added HTTP security headers (fixed Asqatasun#23)"
  webapp - Updated *.xml (spring-*-4.3.xsd instead of spring-*-2.5.xsd)
  contrast-finder-webapp : fixed Logback configuration
  updated .gitignore
  Updated CHANGELOG
  contrast-finder-webapp: updated pom.xml
  contrast-finder-webapp: upgraded springframework.security (4.2.2 instead of 4.2.1)
  contrast-finder-webapp: upgraded springframework (4.3.7 instead of 4.3.6)
  contrast-finder-webapp : updated Logback configuration
  fix DockerFile
  contrast-finder-webapp : added Logback configuration
  contrast-finder-hsv/src/test/ : added Logback configuration
  Changed LOG dependency (logback + slf4j instead of log4j)
  DOC - Updated "Other contrast tools" (typo)
  DOC - Updated "Other contrast tools"
  Updated contrast-finder_fr.properties (small fix)
  typo
  fixed Asqatasun#30 - i18n - punctuation errors in english
  fixed Asqatasun#29 webApp - lang-switcher: error on the lang attribute
  .jsp - added appVersion
  .jsp - added comments
  set version to 0.4.5-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant