Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrast calculation is not always visible without scrolling #148

Closed
dzc34 opened this issue Mar 1, 2018 · 2 comments
Closed

contrast calculation is not always visible without scrolling #148

dzc34 opened this issue Mar 1, 2018 · 2 comments
Labels

Comments

@dzc34
Copy link
Member

dzc34 commented Mar 1, 2018

Observed behaviour

in french by @ffoodd

(...) le résultat du calcul de contraste ne soit pas toujours visible sans scroller. Je trouverais confortable de n’avoir à scroller que quand on cherche une valeur alternative

the result of the contrast calculation is not always visible without scrolling. I'd find it comfortable to have to scroll only when you're looking for an alternative value.

@dzc34 dzc34 added feature feature request category: UI labels Mar 1, 2018
dzc34 added a commit to dzc34/Contrast-Finder that referenced this issue Apr 21, 2018
@dzc34 dzc34 closed this as completed in 4fd2c33 Apr 21, 2018
@dzc34
Copy link
Member Author

dzc34 commented Apr 21, 2018

fixed
@ffoodd, what do you think?


<div id="currentRatio" aria-live="off" class="col-lg-1">
   <div id="isValidRatio"> 
      <img id="isValidRatio_Passed" src="ico-passed-m.png" 
           alt="Le contraste de vos couleurs est suffisant."
           class="hidden">
      <img id="isValidRatio_Failed" src="ico-failed-m.png" 
           alt="Le contraste de vos couleurs est insuffisant."> 
    </div>
   <div id="currentRatioTxt">
      <span class="sr-only">Ratio actuel :</span> 
      <output form="colorModel" 
              for="ratio background-input foreground-input"
              name="currentRatioData" 
              id="currentRatioData">1.02</output> 
    </div>
</div>

@ffoodd
Copy link

ffoodd commented Apr 23, 2018

It's perfect!

Thanks a lot 😀

dzc34 added a commit that referenced this issue Apr 24, 2018
----------------------

  set version to 0.9.0
  Updated i18n files (add "nav.language" and "nav.language-switching")
  Spanish i18n file: added some "lang=en" attributs
  Spanish i18n file: fixed pt => px conversion
  Add Spanish i18n file
  Update i18files
  #136 - Webapp: fixed pt => px conversion ("Help" > "Text size understanding")
  webapp i18n - Languages switch: added spanish language
  Webapp - Hidding current contrast on default page
  DOC - Howto-use.md / Update for the pt => px conversion section
  Added missing files
  Fixed #148 - Contrast calculation is visible without scrolling
  Added getConstrastRatio2DigitRound() method to engine/utils/(...)/ContrastChecker.java
  updated i18n files for #148
  Updated i18n files
  set version to 0.8.7-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants