Simplate work #481

pjz · 2015-07-30T01:22:18Z

Get rid of is_bound and make all simplates require at least three sections, per #297

chadwhitacre · 2015-07-30T04:22:43Z

@pjz I've updated our labels a bit to fit the rest of Gratipay (nixed 0 - Whatever and 2 - Blah, which were empty anyway; renamed 1 - Ready to Ready to Start and 3 - Done to Review). When this is ready, apply the Review label, and it will show up in our Gratipay-global Review queue. :-)

chadwhitacre · 2015-08-09T21:49:20Z

aspen/renderers.py

@@ -0,0 +1,5 @@
+
+# for backwards compatibility with aspen-renderer modules


Or should we update all of the renderers along with this PR?

Baby steps. Let's not break backward compatibility just yet. Esp. Since we might be breaking simplates out entirely.

chadwhitacre · 2015-08-10T12:20:14Z

@pjz I'm applying Review to this, ya?

pjz · 2015-08-10T14:32:53Z

Yes. Sorry, forgot about that.

pjz · 2015-08-11T19:44:18Z

Note this also fixes #417, as a website object is no longer needed to instantiate a simplate.

pjz · 2015-08-12T19:50:54Z

I get the feeling @whit537 has been avoiding this review.

chadwhitacre · 2015-08-12T20:15:16Z

I would say "warming up to it." ;-)

pjz · 2015-08-12T20:16:29Z

po-TAY-to, po-TAH-to...

chadwhitacre · 2015-08-12T20:16:51Z

!m @pjz

Regularize simplates so they all require at least 3 sections now: 2 of python, and at least one template

Also elucidate response context modification

chadwhitacre · 2015-08-12T23:49:47Z

aspen/simplates/renderers/json_dump.py

@@ -8,7 +8,7 @@
 from __future__ import unicode_literals

 from . import Renderer, Factory
-from .. import json
+from ... import json


We still have aspen.json? Weren't we going to move that to aspen.simplates.json?

It's the json registry; It'll move, I just haven't gotten there yet.

So maybe even to aspen.simplates.renderers.json_dump?

The concept of `state` belongs to algorithm.py, which shouldn't leak over into simplates.

pjz · 2015-08-13T02:34:47Z

uhh... WTF? why are you doing this work here instead of merging my PR and then doing it in new PRs?

chadwhitacre · 2015-08-13T02:46:37Z

Yeah, yeah, sorry, got carried away. I made a new PR at #490 and force-pushed the last three commits off of here, but I maybe clobbered 1aec879?

chadwhitacre · 2015-08-13T02:47:09Z

(@pjz You okay with d5d48d2, at least?)

pjz · 2015-08-13T02:47:34Z

It's okay. Yeah, I repushed 1aec879. d5d48d2 is fine.

chadwhitacre · 2015-08-13T02:49:17Z

Cool.

chadwhitacre · 2015-08-13T02:49:46Z

We can't get a test for the _ordinal call?

chadwhitacre · 2015-08-13T02:50:27Z

Other than that I think I just need to grok https://github.com/gratipay/aspen-python/pull/481/files#r36929962.

pjz · 2015-08-13T02:56:27Z

There's as many tests for _ordinal as there were for what it replaced (which was a Class with a fancy magic handler, IIRC). I'm really not sure what to test with it; it's a straightforward mapping function.

chadwhitacre · 2015-08-13T02:58:35Z

Well, what we want to test is that it's called properly from wherever we had _ordinal[foo]. No?

pjz · 2015-08-13T03:00:58Z

Well, where we originally had ORDINALS[foo], actually, but yes.

pjz · 2015-08-13T03:02:38Z

That was limited to this file, because it's declared here and not imported anywhere else. I think it's actually limited to the four times in this block (twice per error message).

chadwhitacre · 2015-08-13T03:02:43Z

Well, where we originally had ORDINALS[foo], actually, but yes.

I guess we didn't have a test for it before this PR. Out of scope!

Simplate work

chadwhitacre · 2015-08-13T03:03:00Z

!m @pjz

chadwhitacre · 2015-09-11T03:18:18Z

Follow-ons: #490, #491.

Simplate work

chadwhitacre added Review and removed Review labels Jul 30, 2015

pjz force-pushed the simplate_work branch 2 times, most recently from db2c58b to a7129ad Compare July 30, 2015 15:57

pjz mentioned this pull request Jul 31, 2015

factor out simplates #341

Closed

pjz force-pushed the simplate_work branch from 66758a8 to e9a9726 Compare August 2, 2015 19:20

chadwhitacre reviewed Aug 9, 2015
View reviewed changes

chadwhitacre added the Review label Aug 10, 2015

chadwhitacre mentioned this pull request Aug 10, 2015

Radar 19 gratipay/inside.gratipay.com#304

Closed

pjz added 13 commits August 12, 2015 16:24

Get rid of is_bound; all simplates require 3 parts now

c9980cf

Regularize simplates so they all require at least 3 sections now: 2 of python, and at least one template

rename _unbound_parse_specline without the unbound

d67e9fe

simplify content-type setting

bae8e85

remove unused mtime arg/prop

6935e82

Renderer loading/registry now in aspen.renderers

259b7d9

Move simplates to their own submodule

15f1d14

remove resource base class

ca9fe72

simplify StaticResource

202c36a

simplify ordinalization and rename media_type

43657cb

Move renderers under simplates

1caabad

Factor out simplate defaults

801c1a5

Default Response creation moved to algorithm

492d2ca

Also elucidate response context modification

Stop creating Responses in simplates

1c27127

chadwhitacre reviewed Aug 12, 2015
View reviewed changes

Refer to context instead of state

d5d48d2

The concept of `state` belongs to algorithm.py, which shouldn't leak over into simplates.

chadwhitacre mentioned this pull request Aug 13, 2015

refactor resources #490

Merged

chadwhitacre force-pushed the simplate_work branch from ff34ad0 to d5d48d2 Compare August 13, 2015 02:41

Fix minor issues found in code review

1aec879

chadwhitacre force-pushed the simplate_work branch from 1aec879 to d5d48d2 Compare August 13, 2015 02:44

chadwhitacre added a commit that referenced this pull request Aug 13, 2015

Merge pull request #481 from gratipay/simplate_work

100854d

Simplate work

chadwhitacre merged commit 100854d into master Aug 13, 2015

chadwhitacre deleted the simplate_work branch August 13, 2015 03:02

chadwhitacre mentioned this pull request Aug 13, 2015

roadmap to 1.0 #357

Open

36 tasks

This was referenced Aug 13, 2015

make simplates easier to instantiate #417

Closed

Require multiple sections in all simplates #297

Closed

Add a test to show #296 works now #498

Merged

stop requiring a specline in negotiated simplates #296

Closed

chadwhitacre mentioned this pull request Sep 3, 2015

implement aspen.simplate.context #30

Closed

Changaco pushed a commit that referenced this pull request Mar 11, 2016

Merge pull request #481 from gratipay/simplate_work

0230420

Simplate work

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplate work #481

Simplate work #481

pjz commented Jul 30, 2015

chadwhitacre commented Jul 30, 2015

chadwhitacre Aug 9, 2015

pjz Aug 9, 2015

chadwhitacre commented Aug 10, 2015

pjz commented Aug 10, 2015

pjz commented Aug 11, 2015

pjz commented Aug 12, 2015

chadwhitacre commented Aug 12, 2015

pjz commented Aug 12, 2015

chadwhitacre commented Aug 12, 2015

chadwhitacre Aug 12, 2015

pjz Aug 13, 2015

chadwhitacre Aug 13, 2015

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

pjz commented Aug 13, 2015

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Sep 11, 2015

		@@ -0,0 +1,5 @@

		# for backwards compatibility with aspen-renderer modules

Simplate work #481

Simplate work #481

Conversation

pjz commented Jul 30, 2015

chadwhitacre commented Jul 30, 2015

chadwhitacre Aug 9, 2015

Choose a reason for hiding this comment

pjz Aug 9, 2015

Choose a reason for hiding this comment

chadwhitacre commented Aug 10, 2015

pjz commented Aug 10, 2015

pjz commented Aug 11, 2015

pjz commented Aug 12, 2015

chadwhitacre commented Aug 12, 2015

pjz commented Aug 12, 2015

chadwhitacre commented Aug 12, 2015

chadwhitacre Aug 12, 2015

Choose a reason for hiding this comment

pjz Aug 13, 2015

Choose a reason for hiding this comment

chadwhitacre Aug 13, 2015

Choose a reason for hiding this comment

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

pjz commented Aug 13, 2015

pjz commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Aug 13, 2015

chadwhitacre commented Sep 11, 2015