Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

improve: port middleware to extension #579

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

improve: port middleware to extension #579

wants to merge 10 commits into from

Conversation

ruheni
Copy link

@ruheni ruheni commented Aug 20, 2023

This PR migrates the package from Prisma middleware to Prisma Client extensions because middleware was deprecated in v4.16.0.

Would we separate prisma-redis-middleware into two packages: a middleware & a client extension, or migrate the middleware to Prisma Client extensions? The latter would be a breaking change, and the former would be a safe alternative for those who would still like to use it as middleware.

Happy to hear your thoughts and make any necessary changes.

Most of the code was reusable from the middleware with a few minor tweaks such as argument names.

TODO:

  • Add tests

Closes #546

@phiko-misc
Copy link

Is there any update on this?

@ruheni
Copy link
Author

ruheni commented Sep 21, 2023

@Asjas, I would appreciate your input on the way forward for changes. :)

@net-tech
Copy link

net-tech commented Oct 2, 2023

@ruheni Are tests the only thing missing or is the implementation not finished? Looking into whether I should fork your fork so I can get access to this sooner if the author doesn't reply soon.

@Asjas
Copy link
Owner

Asjas commented Oct 3, 2023

Would we separate prisma-redis-middleware into two packages: a middleware & a client extension, or migrate the middleware to Prisma Client extensions?

Whichever is the easiest, I don't make heavy use of this library anymore so whichever one you want to implement I don't see an issue with 🙁

@phiko-misc
Copy link

phiko-misc commented Oct 18, 2023

Some news? @ruheni

@ruheni
Copy link
Author

ruheni commented Oct 23, 2023

👋

Picking this up this week. I'll convert the repo to a monorepo containing the extension and middleware. Will keep you posted and share more updates!

Apologies for the delayed updates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Update using Client Extensions
4 participants