Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich Avalanche nodes info #41

Merged
merged 9 commits into from
May 12, 2023
Merged

Enrich Avalanche nodes info #41

merged 9 commits into from
May 12, 2023

Conversation

Nuttymoon
Copy link
Contributor

@Nuttymoon Nuttymoon commented May 12, 2023 •
edited
Loading

Linked issues

Changes

  • ash_sdk
    • Use get_json_rpc_req_result for all JSON RPC API calls
    • Add get_network_name() and is_bootstrapped() functions in jsonrpc::info module
    • Store node public_ip as IpAddr instead of String
    • Avoid AvalancheNode.update_info() failing if the info.uptime endpoint returns an error because the node is not a validator
  • ash_cli
    • Add avalanche node is-bootstrapped command
    • Fix prints templating
  • CI
    • Enable cache in Actions workflows using Swatinem/rust-cache@v2

Additional comments

Still using our fork of avalanche-types-rs

@Nuttymoon Nuttymoon requested a review from gboutry May 12, 2023 13:19
@Nuttymoon Nuttymoon merged commit 2657c59 into main May 12, 2023
@Nuttymoon Nuttymoon deleted the 32-39-nodes-info branch May 12, 2023 15:21
@Nuttymoon Nuttymoon mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gboutry gboutry gboutry approved these changes

@leopaul36 leopaul36 Awaiting requested review from leopaul36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Nuttymoon @gboutry