Skip to content

Commit

Permalink
Combine coverage with python 3.7
Browse files Browse the repository at this point in the history
When running `coverage combine` under python 3.8, function definition lines
after function decorators are marked as not executed. This issue doesn't happen
with earlier versions of python, so using v3.7 instead.
See nedbat/coveragepy#866 for an explanation.
  • Loading branch information
ArturKlauser committed Dec 4, 2019
1 parent d7dbca9 commit c53c8e7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,12 @@ jobs:
fetch-depth: 1 # no history, just HEAD
- name: Set up Python
uses: actions/setup-python@v1
with:
# Python3.8 computes coverage lines differently from <=3.7, leading to
# 'def' lines after function decorators being reported as uncovered.
# See https://github.com/nedbat/coveragepy/issues/866.
# Thus we have to stick to v3.7 for coverage combine and its reporting.
python-version: 3.7
- name: Install dependencies
run: |
# python -m pip install --upgrade pip
Expand Down

0 comments on commit c53c8e7

Please sign in to comment.