Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AndroidImage implementation #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tynn
Copy link

@tynn tynn commented Jul 20, 2023

The implementation seems broken.

  1. It's not possible to create an instance without a mask
  2. The native method isn't named correctly
    • Since self is never used I made it static
    • With the static native I made use of the super constructor
    • I kept the pointer field protected

I still have issues with this code, but it might be related to my Bitmap as I get following the error

new Image failed as bitmap width != stride

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant