Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the first test script #83

Merged
merged 3 commits into from
May 23, 2024
Merged

Add the first test script #83

merged 3 commits into from
May 23, 2024

Conversation

mipo1357
Copy link
Collaborator

@mipo1357 mipo1357 commented May 21, 2024

Added tests directory in examples, added simple tests for metadata. Vitest is used for testing framework.
You can run it with npm run test.

Copy link
Collaborator

@jamie-lemon jamie-lemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does vitest depend on vite?

When I looked vitest looked like a nice front-end package, but it seems you can run vitest without it I think.

"version": "0.0.0",
"type": "module",
"scripts": {
"dev": "vite",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we need vite here?

"devDependencies": {
"mupdf": "^0.2.1",
"typescript": "^5.2.2",
"vite": "^5.2.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we need vite here?

@mipo1357
Copy link
Collaborator Author

The vitest example I was referring to was creating an environment from vite, so the code was still there. I deleted it.
I have confirmed that it does indeed work with vitest only.

@jamie-lemon jamie-lemon merged commit ab8a273 into master May 23, 2024
1 check passed
@jamie-lemon jamie-lemon deleted the add-test branch May 23, 2024 15:01
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants