Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display IP region of comment (#418) #447

Merged
merged 5 commits into from
Mar 6, 2023
Merged

feat: display IP region of comment (#418) #447

merged 5 commits into from
Mar 6, 2023

Conversation

qwqcode
Copy link
Member

@qwqcode qwqcode commented Mar 6, 2023 •
edited
Loading

TODOs

  • Backend API
  • Frontend UI
  • Docs

New config options

# IP 归属地
ip_region:
  # 启用 IP 归属地展示
  enabled: false
  # 数据文件路径 (.xdb 格式)
  db_path: "./data/ip2region.xdb"
  # 显示精度 ["province", "city", "country"]
  precision: "province"

Note

ip_region.enabled default is false

Consider the privacy principles, only provide for Chinese locale at present, some warning for users need to be added for user privacy postpone.

@qwqcode
ip_region backend api
21da98f 
Signed-off-by: qwqcode <[email protected]>
@qwqcode qwqcode changed the title feat: display IP region of comment feat: display IP region of comment (#418) Mar 6, 2023
@qwqcode qwqcode linked an issue Mar 6, 2023 that may be closed by this pull request
希望能够支持 IP 属地显示 #418
Closed
@qwqcode
frontend ui support
9884f15 
Signed-off-by: qwqcode <[email protected]>
@qwqcode
fix backend
66461f6 
Signed-off-by: qwqcode <[email protected]>
@qwqcode
handle mutiple ip case
0d77c90 
Signed-off-by: qwqcode <[email protected]>
@qwqcode
add docs
d2a9f8b 
Signed-off-by: qwqcode <[email protected]>
@qwqcode qwqcode requested a review from monsterxcn March 6, 2023 13:49
monsterxcn
monsterxcn approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@monsterxcn monsterxcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好好好！

@qwqcode qwqcode merged commit fccebf8 into master Mar 6, 2023
@qwqcode qwqcode deleted the feat/ip_region branch March 6, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsterxcn monsterxcn monsterxcn approved these changes

Assignees
No one assigned
Labels
size/L
Projects
Artalk 2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

希望能够支持 IP 属地显示
2 participants
@qwqcode @monsterxcn