-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few small issues #1
Comments
Thanks for reporting this @matthewjacobson 👍 I'll take care of it |
TYVM @rubentd 💜 💜 💜 |
rubentd
added a commit
that referenced
this issue
Jul 30, 2022
Merged
rubentd
added a commit
that referenced
this issue
Jul 30, 2022
jakerockland
pushed a commit
that referenced
this issue
May 24, 2023
adding support for MinterHolderV4 & MinterSetPriceERC20V4 minters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! I ran into a few small issues when setting up this front end with the plottables contract.
Here
data.projects
was sorted in the opposite direction than was coded for so the pagination wasn't working correctly. My simple fix:const { projectId } = data.projects[0];
I was having an issue with the useProject subgraph query. Upon further investigation the contract address that the subgraph was expecting is all lowercase. Not sure if this would be an issue for other PBAB contracts but just wanted to add a note here. It was easily fixed by just changing the REACT_APP_CORE_CONTRACT_ADDRESS .env variable to match what was expected by the subgraph.
Here I believe the contract address is expected to be in the REACT_APP_GENERATOR_URL .env variable directly. This matches up with this line as well. This was causing all of the live links and iframes to be broken. Easy fix:
src={
${generatorUrl}/${tokenId}}
or change line 75 to match 39.That is all I have found so far. Haven't had a chance to test out minting functionality yet though. Happy to put this in a PR - just let me know.
Anyway thanks so much for putting this together!
The text was updated successfully, but these errors were encountered: