Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few small issues #1

Closed
matthewjacobson opened this issue Jul 28, 2022 · 2 comments
Closed

a few small issues #1

matthewjacobson opened this issue Jul 28, 2022 · 2 comments
Assignees

Comments

@matthewjacobson
Copy link
Contributor

Hello! I ran into a few small issues when setting up this front end with the plottables contract.

  1. Here data.projects was sorted in the opposite direction than was coded for so the pagination wasn't working correctly. My simple fix: const { projectId } = data.projects[0];

  2. I was having an issue with the useProject subgraph query. Upon further investigation the contract address that the subgraph was expecting is all lowercase. Not sure if this would be an issue for other PBAB contracts but just wanted to add a note here. It was easily fixed by just changing the REACT_APP_CORE_CONTRACT_ADDRESS .env variable to match what was expected by the subgraph.

  3. Here I believe the contract address is expected to be in the REACT_APP_GENERATOR_URL .env variable directly. This matches up with this line as well. This was causing all of the live links and iframes to be broken. Easy fix: src={${generatorUrl}/${tokenId}} or change line 75 to match 39.

That is all I have found so far. Haven't had a chance to test out minting functionality yet though. Happy to put this in a PR - just let me know.

Anyway thanks so much for putting this together!

@rubentd
Copy link
Contributor

rubentd commented Jul 28, 2022

Thanks for reporting this @matthewjacobson 👍 I'll take care of it

@jakerockland
Copy link
Contributor

TYVM @rubentd 💜 💜 💜

rubentd added a commit that referenced this issue Jul 30, 2022
- Get max project id from project list regardless of sorting
- Make sure core contract address is lower case for the query to work properly
- Fix live view links
@rubentd rubentd mentioned this issue Jul 30, 2022
rubentd added a commit that referenced this issue Jul 30, 2022
jakerockland pushed a commit that referenced this issue May 24, 2023
adding support for MinterHolderV4 & MinterSetPriceERC20V4 minters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants