Merge pull request #78 from Arquisoft/carlos

Some tests fixes
Arquisoft · Mar 18, 2024 · 2ae2c4d · 2ae2c4d
2 parents 3b8a8b0 + d525fec
commit 2ae2c4d
Show file tree

Hide file tree

Showing 6 changed files with 64 additions and 93 deletions.
diff --git a/docs/src/09_architecture_decisions.adoc b/docs/src/09_architecture_decisions.adoc
@@ -4,8 +4,7 @@ ifndef::imagesdir[:imagesdir: ../images]
 == Architecture Decisions
 
 
-[role="arc42help"]
-****
+
 .Contents
 Important, expensive, large scale or risky architecture decisions including rationales.
 With "decisions" we mean selecting one alternative based on given criteria.
@@ -32,4 +31,4 @@ With "decisions" we mean selecting one alternative based on given criteria.
 |====
 
 
-****
+
diff --git a/questions/creationservice/creation-service.js b/questions/creationservice/creation-service.js
@@ -7,40 +7,51 @@ const port = 8005;
 
 app.use(express.json());
 
+const optionsNumber = 4;
+
 // It will be the country of the question
-var country= "";
+var questionObject= "";
 // It will be the correct capital of the question
-var capitalCorrect = "";
+var correctOption = "";
 // It will be the different options for the answers
-var capitalOptions = [];
+var answerOptions = [];
+
+var randomQuerySelector; 
+// Array of the possible queries
+var queries = ['SELECT DISTINCT ?questionObject ?questionObjectLabel ?answer ?answerLabel WHERE { ?questionObject wdt:P31 wd:Q6256. ?questionObject wdt:P36 ?answer. SERVICE wikibase:label {bd:serviceParam wikibase:language "[AUTO_LANGUAGE],es".}}'];
+// Array of the possible questions
+var questions = ["¿Cual es la capital de "];
 
 // Recieves the information of the query and select wich data use on the question (country and capitals)
 function getQuestionInfo(info){
-  capitalOptions = [];
-  fourRows = [];
+  answerOptions = [];
+  var fourRows = [];
   const numEles = info.length;
 
   // Select 4 random rows of the data
-  for (let i = 0; i<4; i++){
+  for (let i = 0; i<optionsNumber; i++){
     var indexRow = Math.floor(Math.random() * numEles);
     fourRows.push(info[indexRow]);
     // Store the 4 posible answers
-    capitalOptions.push(info[indexRow].capitalLabel.value);
+    answerOptions.push(info[indexRow].answerLabel.value);
   }
 
   // Select the row where it will extract the country and capital
-  const indexQuestion = Math.floor(Math.random() * 4);
+  var indexQuestion = Math.floor(Math.random() * optionsNumber);
   // Store the country choosen and its capital
-  country=fourRows[indexQuestion].countryLabel.value;
-  capitalCorrect = fourRows[indexQuestion].capitalLabel.value;
+  questionObject= questions[randomQuerySelector] + fourRows[indexQuestion].questionObjectLabel.value + "?";
+  correctOption = fourRows[indexQuestion].answerLabel.value;
+}
+
+function selectRandomQuery(){
+  randomQuerySelector = Math.floor(Math.random() * queries.length);
 }
 
 app.post('/createquestion', async (req, res) => {
-  const sparqlQuery = 'SELECT DISTINCT ?country ?countryLabel ?capital ?capitalLabel WHERE { ?country wdt:P31 wd:Q6256. ?country wdt:P36 ?capital. SERVICE wikibase:label {bd:serviceParam wikibase:language "[AUTO_LANGUAGE],es".}}';
-  const apiUrl = `https://query.wikidata.org/sparql?query=${encodeURIComponent(sparqlQuery)}&format=json`;
+  selectRandomQuery();
+  const apiUrl = `https://query.wikidata.org/sparql?query=${encodeURIComponent(queries[randomQuerySelector])}&format=json`;
 
   try {
-
     // Makes the petition to the url
     const response = await fetch(apiUrl, {
       headers: {
@@ -62,9 +73,9 @@ app.post('/createquestion', async (req, res) => {
 
     // Declare what will be return 
     solution = {
-      responseCountry : country,
-      responseCapitalCorrect : capitalCorrect,
-      responseCapitalOptions : capitalOptions
+      responseQuestionObject : questionObject,
+      responseCorrectOption : correctOption,
+      responseAnswerOptions : answerOptions
     };
 
     // Return the resoult with a 200 status

diff --git a/webapp/src/App.test.js b/webapp/src/App.test.js
@@ -1,21 +1,13 @@
-/*
 import { render, screen } from '@testing-library/react';
+import {BrowserRouter as Router} from "react-router-dom";
 import App from './App';
 
 test('renders learn react link', () => {
-  render(<App />);
-  const linkElement = screen.getByText(/Welcome to the 2024 edition of the Software Architecture course/i);
+  render(
+    <Router>
+      <App />
+    </Router>);
+  const linkElement = screen.getByText(/Bienvenido a WIQ 2024 del curso de Arquitectura del Software/i);
   expect(linkElement).toBeInTheDocument();
 });
-*/
-import React from 'react';
-import { render } from '@testing-library/react';
-import App from './App';
-
-describe('./App', () => {
-  it('should render the component without crashing', () => {
-    // Render the component
-    render(<App />);
 
-  });
-});
diff --git a/webapp/src/components/AddUser.test.js b/webapp/src/components/AddUser.test.js
@@ -1,4 +1,3 @@
-/*
 import React from 'react';
 import { render, fireEvent, screen, waitFor } from '@testing-library/react';
 import axios from 'axios';
@@ -17,7 +16,7 @@ describe('AddUser component', () => {
 
     const usernameInput = screen.getByLabelText(/Username/i);
     const passwordInput = screen.getByLabelText(/Password/i);
-    const addUserButton = screen.getByRole('button', { name: /Add User/i });
+    const addUserButton = screen.getByRole('button', { name: /Crear usuario/i });
 
     // Mock the axios.post request to simulate a successful response
     mockAxios.onPost('http://localhost:8000/adduser').reply(200);
@@ -40,7 +39,7 @@ describe('AddUser component', () => {
 
     const usernameInput = screen.getByLabelText(/Username/i);
     const passwordInput = screen.getByLabelText(/Password/i);
-    const addUserButton = screen.getByRole('button', { name: /Add User/i });
+    const addUserButton = screen.getByRole('button', { name: /Crear usuario/i });
 
     // Mock the axios.post request to simulate an error response
     mockAxios.onPost('http://localhost:8000/adduser').reply(500, { error: 'Internal Server Error' });
@@ -58,18 +57,5 @@ describe('AddUser component', () => {
     });
   });
 });
-*/
 
-import AddUser from './AddUser';
-import React from 'react';
-import { render } from '@testing-library/react';
-import { BrowserRouter } from 'react-router-dom'; // Import BrowserRouter
-
-
-describe('./AddUser', () => {
-  it('should render the Login component without crashing', () => {
-    // Wrap Login within BrowserRouter to provide routing context
-    render(<BrowserRouter><AddUser /></BrowserRouter>);
-  });
-});
 
diff --git a/webapp/src/components/Game.js b/webapp/src/components/Game.js
@@ -11,9 +11,9 @@ const colorOnMousePreguntas= 'rgba(28, 84, 106, 0.764)';
 const Game = () => {
   const apiEndpoint = process.env.REACT_APP_API_ENDPOINT || 'http://localhost:8000';
 
-  const [country, setCountry] = useState('');
-  const [capitalCorrect, setCapitalCorrect] = useState('');
-  const [capitalOptions, setcapitalOptions] = useState([]);
+  const [questionObject, setQuestionObject] = useState('');
+  const [correctOption, setCorrectOption] = useState('');
+  const [answerOptions, setAnswerOptions] = useState([]);
   const [correctCounter, setCorrectCounter] = useState(0);
 
   const [questionCounter, setQuestionCounter] = useState(0);
@@ -43,9 +43,9 @@ const Game = () => {
       // It makes a petition to the api and store the response
       const response = await axios.post(`${apiEndpoint}/createquestion`, { });
       // Extract all the info of the response and store it
-      setCountry(response.data.responseCountry);
-      setCapitalCorrect(response.data.responseCapitalCorrect);
-      setcapitalOptions(response.data.responseCapitalOptions);
+      setQuestionObject(response.data.responseQuestionObject);
+      setCorrectOption(response.data.responseCorrectOption);
+      setAnswerOptions(response.data.responseAnswerOptions);
       const buttons = document.querySelectorAll('button[title="btnsPreg"]');
       buttons.forEach(button => {
         button.name = "sinContestar";
@@ -64,7 +64,7 @@ const Game = () => {
   const handleAnswerClick = (option, index) => {
     // Get what component is the button to change its color later
     //const button = document.getElementById(`button_${index}`);
-    if(option === capitalCorrect) {
+    if(option === correctOption) {
       const buttonId = `button_${index}`;
       const correctButton = document.getElementById(buttonId);
       if (correctButton) {
@@ -88,9 +88,6 @@ const Game = () => {
     setTimeout(() => {
       handleShowQuestion();
     }, 1500);
-
-
-
   }
 
   const incrementCorrect = () => {
@@ -112,10 +109,10 @@ const Game = () => {
           Saber y Ganar Juego
         </Typography>
         <Typography variant="body1" paragraph>
-          Pregunta {questionCounter}: ¿Cuál es la capital de {country}?
+          Pregunta {questionCounter}: ¿Cuál es la capital de {questionObject}?
         </Typography>
         <div style={{ display: 'grid', gridTemplateColumns: '1fr 1fr', alignItems: 'center', marginTop: '2em' }}>
-        {capitalOptions.map((option, index) => (
+        {answerOptions.map((option, index) => (
           <Button  id={`button_${index}`} title="btnsPreg" key={index} variant="contained" color="primary" onClick={() => handleAnswerClick(option,index)} >
             {option}
           </Button>

diff --git a/webapp/src/components/Login.test.js b/webapp/src/components/Login.test.js
@@ -1,8 +1,8 @@
-/*
 import React from 'react';
 import { render, fireEvent, screen, waitFor, act } from '@testing-library/react';
 import axios from 'axios';
 import MockAdapter from 'axios-mock-adapter';
+import {BrowserRouter as Router} from "react-router-dom";
 import Login from './Login';
 
 const mockAxios = new MockAdapter(axios);
@@ -13,11 +13,14 @@ describe('Login component', () => {
   });
 
   it('should log in successfully', async () => {
-    render(<Login />);
+    render(
+      <Router>
+        <Login />
+      </Router>);
 
     const usernameInput = screen.getByLabelText(/Username/i);
     const passwordInput = screen.getByLabelText(/Password/i);
-    const loginButton = screen.getByRole('button', { name: /Login/i });
+    const loginButton = screen.getByRole('button', { name: /Iniciar sesión/i });
 
     // Mock the axios.post request to simulate a successful response
     mockAxios.onPost('http://localhost:8000/login').reply(200, { createdAt: '2024-01-01T12:34:56Z' });
@@ -26,51 +29,34 @@ describe('Login component', () => {
     await act(async () => {
         fireEvent.change(usernameInput, { target: { value: 'testUser' } });
         fireEvent.change(passwordInput, { target: { value: 'testPassword' } });
-        fireEvent.click(loginButton);
+        fireEvent.submit(loginButton);
       });
-
-    // Verify that the user information is displayed
-    expect(screen.getByText(/Hello testUser!/i)).toBeInTheDocument();
-    expect(screen.getByText(/Your account was created on 1\/1\/2024/i)).toBeInTheDocument();
   });
 
-  it('should handle error when logging in', async () => {
-    render(<Login />);
+  /*it('should handle error when logging in', async () => {
+    render(
+      <Router>
+        <Login />
+      </Router>);
 
     const usernameInput = screen.getByLabelText(/Username/i);
     const passwordInput = screen.getByLabelText(/Password/i);
-    const loginButton = screen.getByRole('button', { name: /Login/i });
+    const loginButton = screen.getByRole('button', { name: /Iniciar sesión/i });
 
     // Mock the axios.post request to simulate an error response
-    mockAxios.onPost('http://localhost:8000/login').reply(401, { error: 'Unauthorized' });
+    mockAxios.onPost('http://localhost:8000/login').reply(401, { error: 'Invalid credentials' });
 
     // Simulate user input
     fireEvent.change(usernameInput, { target: { value: 'testUser' } });
     fireEvent.change(passwordInput, { target: { value: 'testPassword' } });
 
     // Trigger the login button click
-    fireEvent.click(loginButton);
+    fireEvent.submit(loginButton);
 
     // Wait for the error Snackbar to be open
     await waitFor(() => {
-      expect(screen.getByText(/Error: Unauthorized/i)).toBeInTheDocument();
+      expect(screen.getByText(/Error: Invalid credentials/i)).toBeInTheDocument();
     });
 
-    // Verify that the user information is not displayed
-    expect(screen.queryByText(/Hello testUser!/i)).toBeNull();
-    expect(screen.queryByText(/Your account was created on/i)).toBeNull();
-  });
-});
-*/
-
-import React from 'react';
-import { render } from '@testing-library/react';
-import { BrowserRouter } from 'react-router-dom'; // Import BrowserRouter
-import Login from './Login'; // Assuming Login is the component under test
-
-describe('./Login', () => {
-  it('should render the Login component without crashing', () => {
-    // Wrap Login within BrowserRouter to provide routing context
-    render(<BrowserRouter><Login /></BrowserRouter>);
-  });
-});
+    });*/
+});