Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

60 image delete function not working #84

Closed
wants to merge 8 commits into from
Closed

60 image delete function not working #84

wants to merge 8 commits into from

Conversation

UO283428
Copy link
Contributor

@UO283428 UO283428 commented Apr 9, 2023

The function for deleting images works again. Now it is not possible to add an already added photo, the button to clear images only appears once more than one photo is added. Colors have been adapted. Errors are now showned as read messages below.

image
image
image
image

The functionality for adding categories to places is also implemented.

@UO283428 UO283428 added bug Something isn't working High level requirements Oriented to fulfill one requirement of the project. labels Apr 9, 2023
@UO283428 UO283428 added this to the Prototype + Documentation 1.0 milestone Apr 9, 2023
@UO283428 UO283428 linked an issue Apr 9, 2023 that may be closed by this pull request
Add categories to the Places. #77
Closed
uo282892
uo282892 requested changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@uo282892 uo282892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the destination branch to develop.

@UO283428 UO283428 linked an issue Apr 9, 2023 that may be closed by this pull request
Image delete callback function for preview not working. #60
Closed
@UO283428 UO283428 changed the base branch from master to develop April 9, 2023 11:20
@UO283428 UO283428 requested a review from uo282892 April 9, 2023 11:20
@UO283428
Copy link
Contributor Author

UO283428 commented Apr 9, 2023

Change the destination branch to develop.

Hecho, gracias!!

Pelayo-Reguera
Pelayo-Reguera approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@Pelayo-Reguera Pelayo-Reguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the enum class of categories may be exported to an external file but as you want. For the next delivery I also think that we can focus more on improving the aspect of that view instead of adding more features.

Davidmc07
Davidmc07 approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@Davidmc07 Davidmc07 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflicts have to be resolved in order to merge the branch. It could be better to extract the validations in AddPlace to a separate class, but for now it's ok

@UO283428
Copy link
Contributor Author

The conflicts have to be resolved in order to merge the branch. It could be better to extract the validations in AddPlace to a separate class, but for now it's ok

Yes, those conflicts appeared when you merged the pull request that was created after this one. I'll try to solve them.

@UO283428
Copy link
Contributor Author

UO283428 commented Apr 10, 2023 •
edited
Loading

Due to other issues, this pull request is no longer valid and will be closed. Another pull request with more updated code will be created instead

@UO283428 UO283428 closed this Apr 10, 2023
@Pelayo-Reguera Pelayo-Reguera deleted the 60-image-delete-function-not-working branch April 10, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillermoDylan GuillermoDylan GuillermoDylan approved these changes

@Pelayo-Reguera Pelayo-Reguera Pelayo-Reguera approved these changes

@uo282892 uo282892 uo282892 approved these changes

@Davidmc07 Davidmc07 Davidmc07 approved these changes

Assignees

@UO283428 UO283428

Labels
bug Something isn't working High level requirements Oriented to fulfill one requirement of the project.
Projects
None yet
Milestone
Prototype + Documentation 1.0
Development

Successfully merging this pull request may close these issues.

Add categories to the Places. Image delete callback function for preview not working.
5 participants
@UO283428 @Davidmc07 @uo282892 @Pelayo-Reguera @GuillermoDylan