Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Shopping cart delete and adding #84

Merged
merged 5 commits into from
Mar 17, 2022
Merged

Fix Shopping cart delete and adding #84

merged 5 commits into from
Mar 17, 2022

Conversation

danieladov
Copy link
Contributor

This pr fixes:

  • the bug that was caused when deleting an item from the cart, now the total is correctly displayed.
  • Add to cart sums one if the product is already in the shopping cart

Fix #79 and #83

@danieladov danieladov requested a review from UO258220 March 15, 2022 13:16
jesugmend
jesugmend reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@jesugmend jesugmend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now when add to cart button pressed on the same item multiple times, it gets added to the cart properly, but shopping cart little logo does not refresh with the correct value.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@danieladov
Copy link
Contributor Author

Now when add to cart button pressed on the same item multiple times, it gets added to the cart properly, but shopping cart little logo does not refresh with the correct value.

Fixed👍

@UO258220 UO258220 merged commit 27c8cfd into develop Mar 17, 2022
@UO258220
Copy link
Contributor

Closes #79

@jesugmend jesugmend mentioned this pull request Apr 4, 2022
Closed
@danieladov danieladov mentioned this pull request Apr 5, 2022
Closed
@UO258220 UO258220 mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesugmend jesugmend jesugmend left review comments

@UO258220 UO258220 UO258220 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieladov @UO258220 @jesugmend