Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main products #102

Merged
merged 14 commits into from
Apr 4, 2022
Merged

Main products #102

merged 14 commits into from
Apr 4, 2022

Conversation

sebaslh01
Copy link
Contributor

closes #69 . I've only added the carousel of images for each product. Both views need more improvements...

danieladov and others added 12 commits April 4, 2022 09:11
What is missing is that now it gets only 4 pictures for each product, it should take as many images as each product has.
In some views, when accesing direct through the URL, it didnt show the logo, it had to use the absolute public path "/logo.png", instead of "./logo.png".
Copy link
Contributor

@danieladov danieladov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jesugmend jesugmend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working.
Great!

@sebaslh01 sebaslh01 changed the base branch from master to develop April 4, 2022 21:03
@jesugmend jesugmend merged commit 7ab77fe into develop Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Main Products view and Product Details view
3 participants