Discover Changes for Point in Time POC #4
Conversation
Signed-off-by: Arpit Bandejiya <[email protected]>
Arpit-Bandejiya
force-pushed
the
discover-changes
branch
from
6b9347c to
cd0b92f
Compare
| export function getSwitchIndexPatternAppState( | ||
| currentIndexPattern: IndexPattern, | ||
| nextIndexPattern: IndexPattern, | ||
| currentIndexPattern: IndexPattern | PointInTime, |
There was a problem hiding this comment.
In the main implementation the aim is to have the discover page react to IndexPattern and Point in Time similarly. So Here we are thinking to abstract IndexPattern and Point in Time object and have a parent interface which can be used.
There was a problem hiding this comment.
Need a separate field for point in time instead of reusing "indexpattern" fields
| const nextColumns = modifyColumns | ||
| ? currentColumns.filter( | ||
| (column) => | ||
| if (nextIndexPattern.attributes) { |
There was a problem hiding this comment.
This is a crude way to check whether it's a index pattern or point in time. Will have to do a better implementation for the same
| $scope.indexPattern = resolveIndexPatternLoading(); | ||
| $scope.selectedPointInTime = $route.current.locals.savedObjects.pit.pitid || undefined; |
There was a problem hiding this comment.
If there is no pitid in the state, make it undefined
| @@ -294,20 +330,49 @@ function discoverController($element, $route, $scope, $timeout, $window, Promise | |||
| }); | |||
|
|
|||
| $scope.setIndexPattern = async (id) => { | |||
There was a problem hiding this comment.
Ignore this function since the same legacy code.
| @@ -102,6 +103,33 @@ const fetchStatuses = { | |||
|
|
|||
| const app = getAngularModule(); | |||
|
|
|||
| export async function getpits(savedObjectsClient) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -77,6 +77,7 @@ const { | |||
| toastNotifications, | |||
| uiSettings: config, | |||
| visualizations, | |||
| savedObjectsClient, | |||
There was a problem hiding this comment.
We will need savedObjectClient to fetch the PIT saved object. Since we already have the necessary dependencies in the plugin. We have imported it in the discover page
| const params = toSnakeCase({ | ||
| ...defaultParams, | ||
| ...getShardTimeout(config), | ||
| ...request.params, | ||
| }); | ||
|
|
||
| if (params.body.pit) { |
There was a problem hiding this comment.
We will need to make changes in the search strategy as well since there are some fields which can't be passed in PIT search.
| @@ -49,7 +49,7 @@ export async function getDefaultSearchParams(uiSettingsClient: IUiSettingsClient | |||
| maxConcurrentShardRequests: | |||
| maxConcurrentShardRequests > 0 ? maxConcurrentShardRequests : undefined, | |||
| ignoreThrottled, | |||
| ignoreUnavailable: true, // Don't fail if the index/indices don't exist | |||
| ignoreUnavailable: false, // Don't fail if the index/indices don't exist | |||
There was a problem hiding this comment.
Need to make a different function to be called for fetching the default params for PIT searches.
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya [email protected]
Description
This PR deal with the integration of Point in Time plugin feature in the discover page. These code changes are not independent and will require the rest of the Plugin to work with. This PR primarily for review purposes for the design of discover page.
Meta issue