Notifications sound support

ArnaudLigny · Jul 23, 2015 · b9d5cda · b9d5cda
1 parent d38fffd
commit b9d5cda
Show file tree

Hide file tree

Showing 7 changed files with 43 additions and 4 deletions.
diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json
@@ -84,6 +84,9 @@
     "optionsMinutes": {
         "message": "minute(s)"
     },
+    "optionsCheckboxNotificationSound": {
+        "message": "Play sound"
+    },
     "optionsTestNotifications": {
         "message": "Send test notification"
     },

diff --git a/src/_locales/fr/messages.json b/src/_locales/fr/messages.json
@@ -84,6 +84,9 @@
     "optionsMinutes": {
         "message": "minute(s)"
     },
+    "optionsCheckboxNotificationSound": {
+        "message": "Emettre un son"
+    },
     "optionsTestNotifications": {
         "message": "Envoyer une notification de test"
     },

diff --git a/src/background.js b/src/background.js
@@ -151,12 +151,16 @@
   }
 
   function showNotification() {
+    var sound = false;
     if (!chrome.notifications || localStorage.notifIsActivated != 'true') {
       return;
     }
+    if (localStorage.notifIsSound == 'true') {
+      sound = true;
+    }
     new NotificationsCount(function (count) {
       if (count !== false && count > 0) {
-        renderNotification(count);
+        renderNotification(count, sound);
       }
     });
   }
@@ -210,7 +214,7 @@
   }
 
   // notitifcation renderer
-  function renderNotification(count) {
+  function renderNotification(count, sound) {
     var opt = {
       type: "basic",
       title: chrome.i18n.getMessage('notificationTitle'),
@@ -227,6 +231,11 @@
       iconUrl: "icon-48.png"
     };
     var notification = chrome.notifications.create('showNotification', opt, function() {
+      if (sound) {
+        var notifAudio = new Audio();
+        notifAudio.src = 'knock_brush.mp3';
+        notifAudio.play();
+      }
       if (chrome.runtime.lastError) {
         console.log(chrome.runtime.lastError.message);
         if (chrome.runtime.lastError.message == "Adding buttons to notifications is not supported.") {
@@ -351,6 +360,7 @@
       localStorage.iconShowIngame = true;
       localStorage.notifIsActivated = false;
       localStorage.notifFrequency = 5;
+      localStorage.notifIsSound = true;
     } else if (details.reason == 'update') {
       console.log(manifest.name + " updated from v" + details.previousVersion + " to v" + manifest.version);
     }
@@ -367,7 +377,14 @@
         showNotification();
         break;
       case 'shownotification_test':
-        renderNotification(Math.floor((Math.random()*10)+1));
+        var sound = false;
+        if (!chrome.notifications) {
+          return;
+        }
+        if (localStorage.notifIsSound == 'true') {
+          sound = true;
+        }
+        renderNotification(Math.floor((Math.random()*10)+1), sound);
         break;
     }
   });

diff --git a/src/knock_brush.mp3 b/src/knock_brush.mp3
diff --git a/src/manifest.json b/src/manifest.json
@@ -1,7 +1,7 @@
 {
     "name": "__MSG_extName__",
     "description": "__MSG_extDescription__",
-    "version": "0.1.1",
+    "version": "0.1.2",
     "background": {
         "persistent": false,
         "scripts": [

diff --git a/src/options.html b/src/options.html
@@ -97,6 +97,10 @@ <h3 data-message="optionsSectionUpdatesHeader">Updates</h3>
                 </select>
                 <span data-message="optionsMinutes">minute(s)</span>.
               </div>
+              <div class="checkbox">
+                <input type="checkbox" id="notifIsSound">
+                <label for="notifIsSound" data-message="optionsCheckboxNotificationSound">Play sound</label>
+              </div>
               <div style="margin-top: 10px;">
                 <button id="notifTest" data-message="optionsTestNotifications">Send test notification</button>
               </div>

diff --git a/src/options.js b/src/options.js
@@ -31,6 +31,7 @@
     var inputIconShowIngame = document.getElementById('iconShowIngame');
     var inputNotifIsActivated = document.getElementById('notifIsActivated');
     var inputNotifFrequency = document.getElementById('notifFrequency');
+    var inputNotifIsSound = document.getElementById('notifIsSound');
     var successMessage = document.getElementById('success_message');
     var successTimeout = null;
 
@@ -83,6 +84,12 @@
       } else {
         inputNotifFrequency.value = localStorage.getItem('notifFrequency');
       }
+      // notifIsSound
+      if (localStorage.getItem('notifIsSound') === null) {
+        inputNotifIsSound.checked = true;
+      } else {
+        inputNotifIsSound.checked = (localStorage.getItem('notifIsSound') === 'true');
+      }
     }
     loadOptions();
 
@@ -94,6 +101,7 @@
       localStorage.setItem('iconShowIngame', inputIconShowIngame.checked);
       localStorage.setItem('notifIsActivated', inputNotifIsActivated.checked);
       localStorage.setItem('notifFrequency', inputNotifFrequency.value);
+      localStorage.setItem('notifIsSound', inputNotifIsSound.checked);
       // success message
       clearTimeout(successTimeout);
       successMessage.classList.add('visible');
@@ -125,6 +133,10 @@
       saveOptions();
       chrome.runtime.sendMessage({do: 'shownotification'});
     });
+    document.getElementById('notifIsSound').addEventListener('change', function () {
+      saveOptions();
+      chrome.runtime.sendMessage({do: 'shownotification'});
+    });
 
     // Notification test
     document.getElementById('notifTest').addEventListener('click', function () {