Support export const foo = -1 with allowConstantExport (fixes #43)…

… [publish]
ArnaudBarre · Jul 9, 2024 · a10b96b · a10b96b
1 parent 70dcd5a
commit a10b96b
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.4.8
+
+- Support `export const foo = -1` with `allowConstantExport` (fixes #43)
+
 ## 0.4.7
 
 - Support `export { Component as default }` (fixes #41)

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-refresh",
-  "version": "0.4.7",
+  "version": "0.4.8",
   "type": "module",
   "license": "MIT",
   "scripts": {

diff --git a/src/only-export-components.test.ts b/src/only-export-components.test.ts
@@ -110,6 +110,11 @@ const valid = [
     code: "export const foo = 4; export const Bar = () => {};",
     options: [{ allowConstantExport: true }],
   },
+  {
+    name: "Component and negative number constant with allowConstantExport",
+    code: "export const foo = -4; export const Bar = () => {};",
+    options: [{ allowConstantExport: true }],
+  },
   {
     name: "Component and string constant with allowConstantExport",
     code: "export const CONSTANT = 'Hello world'; export const Foo = () => {};",

diff --git a/src/only-export-components.ts b/src/only-export-components.ts
@@ -102,9 +102,10 @@ export const onlyExportComponents: TSESLint.RuleModule<
           if (
             allowConstantExport &&
             init &&
-            (init.type === "Literal" ||
-              init.type === "TemplateLiteral" ||
-              init.type === "BinaryExpression")
+            (init.type === "Literal" || // 1, "foo"
+              init.type === "UnaryExpression" || // -1
+              init.type === "TemplateLiteral" || // `Some ${template}`
+              init.type === "BinaryExpression") // 24 * 60
           ) {
             return;
           }