Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix in arduino-test-compile.sh #26

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Bug Fix in arduino-test-compile.sh #26

merged 1 commit into from
Feb 25, 2022

Conversation

matteobaccan
Copy link
Contributor

Hi

I have made a little modification on SKETCH_BASENAME determination

My sketch have this name CtlTemp-V4.2.0.ino. For this reason the line

SKETCH_EXTENSION=${SKETCH_FILENAME##*.} # extension of sketch

is correct = .ino
But this line

SKETCH_BASENAME=${SKETCH_FILENAME%%.*} # name without extension / basename of sketch, must match directory name

Create CtlTemp-V4

So I have changed it in a more friendly

SKETCH_BASENAME=${SKETCH_FILENAME%%.$SKETCH_EXTENSION} # name without extension / basename of sketch, must match directory name

So now the SKETCH_BASENAME is CtlTemp-V4.2.0

ciao
matteo

(cherry picked from commit c0ba093)
@ArminJo ArminJo merged commit 9ee4fad into ArminJo:master Feb 25, 2022
@ArminJo
Copy link
Owner

ArminJo commented Feb 25, 2022

Thanks ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants