Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: filter options in the select dropdown #2963

Merged
merged 20 commits into from
Oct 16, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Oct 9, 2020

Summary

Peek 2020-10-13 23-02

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Oct 9, 2020
@brenopolanski brenopolanski marked this pull request as draft October 9, 2020 19:27
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #2963 into develop will increase coverage by 41.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop     #2963       +/-   ##
=============================================
+ Coverage    58.92%   100.00%   +41.07%     
=============================================
  Files          373       366        -7     
  Lines         9325      5219     -4106     
  Branches      1934       966      -968     
=============================================
- Hits          5495      5219      -276     
+ Misses        3603         0     -3603     
+ Partials       227         0      -227     
Flag Coverage Δ
#unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/App.tsx 100.00% <ø> (ø)
...uginManager/PluginManagerModals/PluginUrlModal.vue
src/renderer/store/plugins/vuex-persist.js
...er/services/plugin-manager/adapters/npm-adapter.js
src/renderer/utils/index.js
.../renderer/store/plugins/vuex-persist-migrations.js
...rer/store/migrations/2.4.0 - fix letter avatars.js
...mponents/Menu/MenuDropdown/MenuDropdownHandler.vue
src/renderer/plugins/got.js
src/renderer/splashscreen.js
... and 730 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bbf07f...382f2e4. Read the comment docs.

@brenopolanski brenopolanski marked this pull request as ready for review October 14, 2020 02:01
@faustbrian faustbrian merged commit b774cc8 into develop Oct 16, 2020
@ghost ghost deleted the refactor/component-select-dropdown branch October 16, 2020 04:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants