Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: hide percentage bar if portfolio has no balance #2962

Merged
merged 3 commits into from
Oct 10, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Oct 9, 2020

Summary

https://app.clickup.com/t/8wqeuv

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner October 9, 2020 19:08
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Oct 9, 2020
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #2962 into develop will increase coverage by 41.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop     #2962       +/-   ##
=============================================
+ Coverage    58.92%   100.00%   +41.07%     
=============================================
  Files          373       353       -20     
  Lines         9325      5044     -4281     
  Branches      1934       930     -1004     
=============================================
- Hits          5495      5044      -451     
+ Misses        3603         0     -3603     
+ Partials       227         0      -227     
Flag Coverage Δ
#unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/App.tsx 100.00% <ø> (ø)
src/renderer/components/Wallet/WalletIdenticon.vue
src/renderer/pages/Profile/ProfileAll.vue
.../services/plugin-manager/sandbox/events-sandbox.js
...er/services/crypto/business-resignation.builder.js
...c/renderer/components/Wallet/WalletRenameModal.vue
src/renderer/components/Button/ButtonDropdown.vue
...renderer/components/Selection/SelectionNetwork.vue
...tion/TransactionConfirm/TransactionConfirmIpfs.vue
...allet/WalletButtons/WalletButtonLedgerSettings.vue
... and 717 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0024070...605175f. Read the comment docs.

@faustbrian faustbrian merged commit cb5568e into develop Oct 10, 2020
@ghost ghost deleted the fix/portfolio-nan-CU-8wqeuv branch October 10, 2020 01:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants