Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: reduce wallet card count on dashboard #2958

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Oct 8, 2020

Summary

https://app.clickup.com/t/8pt24r

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner October 8, 2020 22:04
@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Oct 8, 2020
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #2958 into develop will increase coverage by 41.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop     #2958       +/-   ##
=============================================
+ Coverage    58.92%   100.00%   +41.07%     
=============================================
  Files          373       352       -21     
  Lines         9325      5003     -4322     
  Branches      1934       916     -1018     
=============================================
- Hits          5495      5003      -492     
+ Misses        3603         0     -3603     
+ Partials       227         0      -227     
Flag Coverage Δ
#unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/App.tsx 100.00% <ø> (ø)
src/renderer/components/utils/Identicon.vue
src/renderer/store/index.js
src/renderer/components/Plugin/PluginWrapper.vue
...renderer/services/plugin-manager/plugin-sandbox.js
src/renderer/models/profile.js
...renderer/components/Collapse/CollapseAccordion.vue
src/renderer/components/Input/InputDelegate.vue
...c/renderer/components/Wallet/WalletRenameModal.vue
...services/crypto/bridgechain-resignation.builder.js
... and 716 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3f177...837cc40. Read the comment docs.

@faustbrian faustbrian merged commit 4d197c5 into develop Oct 9, 2020
@ghost ghost deleted the refactor/wallets-CU-8pt24r branch October 9, 2020 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants