Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: add profile wallets to recipients search #2948

Merged
merged 14 commits into from
Oct 8, 2020

Conversation

clucasalcantara
Copy link
Contributor

@clucasalcantara clucasalcantara commented Oct 7, 2020

Summary

Solves: https://app.clickup.com/t/8judcy

Add the ability to select a recipient between both profile contacts and added wallets

UI Preview

Screen Shot 2020-10-07 at 19 00 24

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Oct 7, 2020
@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. Status: In Progress The issue or pull request is being worked on. labels Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #2948 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2948   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          350       350           
  Lines         4964      4976   +12     
  Branches       906       909    +3     
=========================================
+ Hits          4964      4976   +12     
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/i18n/common/i18n.ts 100.00% <ø> (ø)
src/domains/contact/pages/Contacts/Contacts.tsx 100.00% <ø> (ø)
...act/components/ContactListItem/ContactListItem.tsx 100.00% <100.00%> (ø)
...contact/components/SearchContact/SearchContact.tsx 100.00% <100.00%> (ø)
...ile/components/SelectRecipient/SelectRecipient.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9bae4...7f4b387. Read the comment docs.

@luciorubeens luciorubeens changed the title fix: wip add profile wallets to recipients search fix: add profile wallets to recipients search Oct 7, 2020
@clucasalcantara clucasalcantara marked this pull request as ready for review October 7, 2020 22:10
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Oct 7, 2020
@faustbrian faustbrian merged commit 601a27b into develop Oct 8, 2020
@ghost ghost deleted the fix/add-profile-wallets-to-recipient-search branch October 8, 2020 01:15
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants