This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
fix: add profile wallets to recipients search #2948
Merged
faustbrian
merged 14 commits into
develop
from
fix/add-profile-wallets-to-recipient-search
Oct 8, 2020
Merged
fix: add profile wallets to recipients search #2948
faustbrian
merged 14 commits into
develop
from
fix/add-profile-wallets-to-recipient-search
Oct 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: High
More than 256 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Status: In Progress
The issue or pull request is being worked on.
labels
Oct 7, 2020
…com:ArkEcosystem/desktop-wallet into fix/add-profile-wallets-to-recipient-search
Codecov Report
@@ Coverage Diff @@
## develop #2948 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 350 350
Lines 4964 4976 +12
Branches 906 909 +3
=========================================
+ Hits 4964 4976 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
luciorubeens
changed the title
fix: wip add profile wallets to recipients search
fix: add profile wallets to recipients search
Oct 7, 2020
…com:ArkEcosystem/desktop-wallet into fix/add-profile-wallets-to-recipient-search
ghost
added
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
and removed
Status: In Progress
The issue or pull request is being worked on.
labels
Oct 7, 2020
…com:ArkEcosystem/desktop-wallet into fix/add-profile-wallets-to-recipient-search
ghost
deleted the
fix/add-profile-wallets-to-recipient-search
branch
October 8, 2020 01:15
ghost
removed
the
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
label
Oct 8, 2020
ghost
mentioned this pull request
Oct 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: High
More than 256 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves: https://app.clickup.com/t/8judcy
Add the ability to select a recipient between both profile contacts and added wallets
UI Preview
Checklist