Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add password protection on Welcome card actions #2946

Merged
merged 3 commits into from
Oct 8, 2020
Merged

feat: add password protection on Welcome card actions #2946

merged 3 commits into from
Oct 8, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Oct 7, 2020

Summary

Require password when profile card options (delete, settings) are selected for a password-protected profile card

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Oct 7, 2020
@faustbrian
Copy link
Contributor

Task linked: CU-8wt5th Profiles that are password protected shouldn't be allowed to get to settings page without inputting password (you can also get to other parts of wallets that way)

@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Oct 7, 2020
@faustbrian faustbrian merged commit 4531ad3 into develop Oct 8, 2020
@ghost ghost deleted the feat/welcome-protected-actions branch October 8, 2020 01:15
@goga-m goga-m mentioned this pull request Oct 8, 2020
Closed
3 tasks
@ghost ghost mentioned this pull request Oct 11, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees
No one assigned
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goga-m @faustbrian