Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: implement new design for the page create profile #2941

Merged
merged 11 commits into from
Oct 8, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Oct 6, 2020

Summary

Task: https://app.clickup.com/t/8wtjy6

Create Profile:

Screenshot from 2020-10-07 10-33-22

Profile Settings:

Screenshot from 2020-10-07 10-33-03

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Oct 6, 2020
@brenopolanski brenopolanski marked this pull request as draft October 6, 2020 18:22
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@fb9bae4). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop     #2941   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?       350           
  Lines              ?      4967           
  Branches           ?       908           
===========================================
  Hits               ?      4967           
  Misses             ?         0           
  Partials           ?         0           
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/domains/profile/i18n.ts 100.00% <ø> (ø)
src/domains/setting/i18n.ts 100.00% <ø> (ø)
...mponents/SelectProfileImage/SelectProfileImage.tsx 100.00% <100.00%> (ø)
...ains/profile/pages/CreateProfile/CreateProfile.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9bae4...2c6c84f. Read the comment docs.

@brenopolanski brenopolanski marked this pull request as ready for review October 7, 2020 13:27
@faustbrian faustbrian merged commit 4f3f177 into develop Oct 8, 2020
@faustbrian faustbrian deleted the refactor/new-create-profile branch October 8, 2020 01:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants