This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat: AIP26 handling #2929
Merged
feat: AIP26 handling #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
…p-wallet into feat/aip-26-handling
clucasalcantara
force-pushed
the
feat/aip-26-handling
branch
from
12a8a6b
to
8848717
Compare
clucasalcantara
force-pushed
the
feat/aip-26-handling
branch
from
8848717
to
2d12890
Compare
clucasalcantara
force-pushed
the
feat/aip-26-handling
branch
from
3206990
to
a7340fc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2929 +/- ##
=============================================
+ Coverage 58.92% 100.00% +41.07%
=============================================
Files 373 351 -22
Lines 9325 5001 -4324
Branches 1934 913 -1021
=============================================
- Hits 5495 5001 -494
+ Misses 3603 0 -3603
+ Partials 227 0 -227
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ghost
added
Status: Needs Review
samharperpittam
approved these changes
Oct 8, 2020
ghost
mentioned this pull request
faustbrian
approved these changes
Oct 12, 2020
|
@clucasalcantara Conflicts |
Solved @luciorubeens updating snapshots and should be ready 👌🏽 |
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
process-urllistener@samharperpittam Some testing guidelines:
1 - Open the ARK Wallet
2 - Paste this deepilnk into your browser and hit enter:
ark:transfer?coin=ark&network=mainnet&recipient=DNjuJEDQkhrJ7cA9FZ2iVXt5anYiM8Jtc9&amount=1.2&memo=ARKCase Scenarios:
1 - With no profile selected: You should receive a warning toast asking you to select a profile
2 - With profile selected but no wallet selected: You should receive a warning toast asking you to select a wallet
3 - With profile and wallet selected: You should be redirected to the transfer page with
amount,smartbridge, andrecipientpre-filled.Checklist