Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ark-multiplayer] refactor: introduce publisher and subscribers #79

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

didymental
Copy link
Contributor

@didymental didymental commented Apr 15, 2024

Key Changes

Hosts

  • Publishes only the ECS (does not publish events)
  • Subscribes only to Event updates

Participants

  • Publishes only Events
  • Subscribes only to ECS Updates

Remove MultiplayerManager + MultiplayerContext because it was dealing with this 4-way relationship all in one class.

Remove MultiplayerEventManager - just inject the publisher delegate into the original EventManager if we want it to publish.

@didymental didymental changed the base branch from main to feat/networking April 15, 2024 08:51
@didymental didymental requested review from markusyeo and ryanpeh and removed request for markusyeo April 15, 2024 08:58
Copy link
Contributor

@markusyeo markusyeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markusyeo markusyeo merged commit 15867fc into feat/networking Apr 15, 2024
1 check passed
@markusyeo markusyeo deleted the refactor/networking-integration branch April 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants