Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure float values are properly encoded by otel tracer #2024

Merged
merged 2 commits into from
Dec 28, 2023
Merged

fix: ensure float values are properly encoded by otel tracer #2024

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a22f4f6
generalize-float-conversion
axiomofjoy Dec 28, 2023
733ad35
Update src/phoenix/trace/otel.py
RogerHYang Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/phoenix/trace/otel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
Optional,
Sequence,
Set,
SupportsFloat,
Tuple,
Union,
cast,
Expand Down Expand Up @@ -394,8 +395,8 @@ def _encode_value(value: AttributeValue) -> AnyValue:
return AnyValue(bool_value=value)
if isinstance(value, int):
return AnyValue(int_value=value)
if isinstance(value, float):
return AnyValue(double_value=value)
if isinstance(value, SupportsFloat):
value = float(value)
RogerHYang marked this conversation as resolved.
Show resolved Hide resolved
if isinstance(value, bytes):
return AnyValue(bytes_value=value)
if isinstance(value, Sequence):
Expand Down
Loading