feat(traces): graphql query for document evaluation summary #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axiomofjoy
reviewed
Dec 6, 2023
src/phoenix/core/traces.py
Outdated
Comment on lines
327
to
332
| # Update number of documents | ||
| num_documents = len(span.retrieval.documents) | ||
| if existing_span: | ||
| num_documents -= len(existing_span.retrieval.documents) | ||
| if num_documents: | ||
| self._num_documents[span_id] += num_documents |
There was a problem hiding this comment.
Can you help understand this update logic?
There was a problem hiding this comment.
it's just the difference, but i was too lazy to create a new variable. my bad
There was a problem hiding this comment.
i think i can call it num_documents_update instead of num_documents, and that should do it
axiomofjoy
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1875
Metrics