Skip to content

Commit

Permalink
fix name
Browse files Browse the repository at this point in the history
  • Loading branch information
mikeldking committed Nov 2, 2023
1 parent 4f38540 commit ea0b642
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/phoenix/trace/trace_eval_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def get_eval_dataframe(self, prefix_columns_with_name: bool = True) -> pd.DataFr
return dataframe


def binary_classifications_to_trace_evals_dataset(
def binary_classifications_to_trace_eval_dataset(
eval_name: str,
classifications_df: pd.DataFrame,
spans_df: pd.DataFrame,
Expand Down
6 changes: 3 additions & 3 deletions tests/trace/test_trace_eval_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
import pandas as pd
from phoenix.trace.trace_eval_dataset import (
TraceEvalDataset,
binary_classifications_to_trace_evals_dataset,
binary_classifications_to_trace_eval_dataset,
)


def test_binary_classifications_to_trace_evals_dataset():
def test_binary_classifications_to_trace_eval_dataset():
# Create mock data
eval_name = "toxicity"
classifications_df = pd.DataFrame({"label": ["toxic", "non-toxic", "toxic", "non-toxic"]})
spans_df = pd.DataFrame({"span_id": [1, 2, 3, 4], "other_column": ["a", "b", "c", "d"]})
rails_map = OrderedDict({True: "toxic", False: "non-toxic"})

# Run the function
result = binary_classifications_to_trace_evals_dataset(
result = binary_classifications_to_trace_eval_dataset(
eval_name, classifications_df, spans_df, rails_map
)

Expand Down
4 changes: 2 additions & 2 deletions tutorials/internal/trace_evals.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@
"metadata": {},
"outputs": [],
"source": [
"from phoenix.trace.trace_eval_dataset import binary_classifications_to_trace_evals_dataset\n",
"from phoenix.trace.trace_eval_dataset import binary_classifications_to_trace_eval_dataset\n",
"\n",
"evaluation_ds = binary_classifications_to_trace_evals_dataset(\n",
"evaluation_ds = binary_classifications_to_trace_eval_dataset(\n",
" eval_name=\"toxicity\",\n",
" classifications_df=eval_classifications_df,\n",
" spans_df=spans_df,\n",
Expand Down

0 comments on commit ea0b642

Please sign in to comment.