Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fix to part1/example6/webpack.config.dev.js to enable HMR #14

Closed
wants to merge 0 commits into from

Conversation

ihilt
Copy link

@ihilt ihilt commented Feb 15, 2016

This issue is referenced here: webpack/webpack-dev-server#326

Signed-off-by: Ian Hilt [email protected]

@AriaFallah
Copy link
Owner

Hey appreciate the pull request. Could you explain the reasoning behind this to me? I read through the issue threads, and from what I saw, the issue was closed and a related pull request was merged.

Also I've never seen this in any other webpack configs.

Am I missing something that implies this is still a problem?

@ihilt
Copy link
Author

ihilt commented Feb 15, 2016

Ah, so maybe ipv6 addresses aren't supported? I had ::1 in my hosts file but not 127.0.0.1. After I added 127.0.0.1 localhost it started working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants