Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnzymeRules #26

Merged
merged 2 commits into from
May 8, 2023
Merged

EnzymeRules #26

merged 2 commits into from
May 8, 2023

Conversation

michel2323
Copy link
Member

@michel2323 michel2323 commented May 4, 2023

This adds EnzymeRules to the supported rules system.

  • There's a new folder, src/Rules, with ChainRules.jl and EnzymeRules.jl checkpointing rules.
  • Removed all deprecated code, including dependencies on other AD tools besides Enzyme, which we need to differentiate the checkpointed loop. Only having Enzyme for that until another mutation-supporting AD tool comes out is okay.
  • Any AD tool supported by one of the two rule systems should work outside the checkpointed loop.
  • I took note of other stuff I want to refactor/change. I leave that for later minor releases.
  • All tests on the examples are done using both Zygote and Enzyme on the code outside of the checkpointed loop.

Project.toml Outdated Show resolved Hide resolved
@michel2323 michel2323 marked this pull request as ready for review May 5, 2023 16:28
Copy link

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can we try disabling the GC on/off?

@michel2323
Copy link
Member Author

Looks great! Can we try disabling the GC on/off?

Yea. It's on my list. I'll put in an option.

@michel2323 michel2323 merged commit 15c9e28 into main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants