Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box model #18

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Box model #18

merged 2 commits into from
Sep 28, 2022

Conversation

michel2323
Copy link
Member

Fix the box model and online checkpointing.

sriharikrishna
sriharikrishna reviewed Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@sriharikrishna sriharikrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some logic may need refining.

sriharikrishna
sriharikrishna reviewed Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@sriharikrishna sriharikrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some logic needs refining

@michel2323
Copy link
Member Author

@sriharikrishna Thank you for the comments!

@michel2323 michel2323 merged commit c5c7db9 into main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriharikrishna sriharikrishna sriharikrishna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michel2323 @sriharikrishna